Skip to content

[IOS] Allow calling setup() multiple times - #732

Closed
c960657 wants to merge 1 commit into
react-native-webrtc:masterfrom
c960657:setup-again
Closed

c960657 wants to merge 1 commit into
react-native-webrtc:masterfrom
c960657:setup-again

Conversation

@c960657

@c960657 c960657 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Some of the options provided in setup() may depend on user preferences or subscribed services.

This PR permits calling setup() again to update the settings.

@sboily

sboily commented Oct 17, 2026

Copy link
Copy Markdown
Member

Thanks @c960657, and sorry for the long wait. The bug is real and wider than calling setup() twice: when the app had run before, the module builds the CallKit provider from the previous launch's stored settings, so even the first setup() of a launch didn't change CallKit. I've taken your change over in #907 (you're credited as co-author), applying the configuration the same way, with one difference: a JavaScript setup() after a native [RNCallKeep setup:] stays ignored, as the README documented; calling [RNCallKeep setup:] again updates the options instead. Checked with a harness that reads the provider's configuration and on an iPhone with iOS 27 (includesCallsInRecents). I'll close this PR once #907 is merged.

@sboily

sboily commented Oct 17, 2026

Copy link
Copy Markdown
Member

Merged as part of #907. Thanks again!

@sboily sboily closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants