You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @c960657, and sorry for the long wait. The bug is real and wider than calling setup() twice: when the app had run before, the module builds the CallKit provider from the previous launch's stored settings, so even the first setup() of a launch didn't change CallKit. I've taken your change over in #907 (you're credited as co-author), applying the configuration the same way, with one difference: a JavaScript setup() after a native [RNCallKeep setup:] stays ignored, as the README documented; calling [RNCallKeep setup:] again updates the options instead. Checked with a harness that reads the provider's configuration and on an iPhone with iOS 27 (includesCallsInRecents). I'll close this PR once #907 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the options provided in
setup()may depend on user preferences or subscribed services.This PR permits calling setup() again to update the settings.