Repository navigation
iOS: destroyProvider method has added - #587
Closed
yunusaydinonline wants to merge 6 commits into
Closed
yunusaydinonline wants to merge 6 commits into
yunusaydinonline wants to merge 6 commits into
Conversation
…eAudioSession method. These changes have made in order to avoid repeating audio session activationinconsistent bluetooth devices and set wrong audio session mode
…/yunusaydinonline/react-native-callkeep into added_ios_destroyProvider_method
manuquentin
requested changes
Mar 1, 2023
| [audioSession setCategory:AVAudioSessionCategoryPlayAndRecord withOptions:AVAudioSessionCategoryOptionAllowBluetooth error:nil]; | ||
|
|
||
| [audioSession setMode:AVAudioSessionModeDefault error:nil]; | ||
| [audioSession setMode:AVAudioSessionModeVoiceChat error:nil]; |
Member
|
Thanks, and sorry for the long wait. Closing: #732 covers the same need (applying new provider options such as the ringtone without restarting) by updating the provider's configuration in place; here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR contains destroying provider manually in order to be able to call setup() method again to activate ringtoneSound changes.
When user picks the new ringtone over UI, the app shouldn't be killed and reopen. In fact, it should change the ringtone sound immediately. So, I added this small helper in order to achieve this functionality.