Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/calculator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function multiply(a: number, b: number): number {
return a * b
}

// BUG: Division by zero is not handled
export function divide(a: number, b: number): number {
if (b === 0) throw new Error("Division by zero")
return a / b
}
7 changes: 3 additions & 4 deletions src/date-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
* Format a date as a human-readable relative string.
* e.g. "2 days ago", "just now", "in 3 hours"
*
* BUG: off-by-one — uses Math.floor where Math.round is needed for days,
* causing "1 day ago" to appear for anything from 12h to 47h.
* Day counts are rounded to the nearest day, so 36 hours reads "2 days ago".
*/
export function formatRelative(date: Date, now: Date = new Date()): string {
const diffMs = now.getTime() - date.getTime()
const diffSec = diffMs / 1000
const diffMin = diffSec / 60
const diffHours = diffMin / 60
const diffDays = Math.floor(diffHours / 24) // BUG: should be Math.round
const diffDays = Math.round(Math.abs(diffHours) / 24)

if (Math.abs(diffSec) < 60) return "just now"
if (Math.abs(diffMin) < 60) {
Expand All @@ -25,7 +24,7 @@ export function formatRelative(date: Date, now: Date = new Date()): string {
const h = Math.round(Math.abs(diffHours))
return diffMs > 0 ? `${h} hour${h !== 1 ? "s" : ""} ago` : `in ${h} hour${h !== 1 ? "s" : ""}`
}
const d = Math.abs(diffDays)
const d = diffDays
return diffMs > 0 ? `${d} day${d !== 1 ? "s" : ""} ago` : `in ${d} day${d !== 1 ? "s" : ""}`
}

Expand Down
33 changes: 27 additions & 6 deletions src/string-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,31 @@ export function reverse(str: string): string {
return str.split("").reverse().join("")
}

// TODO: implement truncate — should truncate at a word boundary, with "..."
// counting toward maxLength. Return unchanged if str.length <= maxLength.
/**
* Truncate a string to maxLength characters, cutting at a word boundary.
* The "..." ellipsis counts toward maxLength, so the result never exceeds it.
* Returns the string unchanged when it already fits.
*
* When maxLength is not long enough to fit the ellipsis itself (<= 3), the
* string is hard-cut to maxLength with no ellipsis, so there is no visible
* truncation marker. A negative maxLength yields an empty string.
*/
export function truncate(str: string, maxLength: number): string {
throw new Error("not implemented")
if (str.length <= maxLength) return str

const ellipsis = "..."
if (maxLength <= ellipsis.length) return str.slice(0, Math.max(0, maxLength))

const candidate = str.slice(0, maxLength - ellipsis.length)
const lastSpace = candidate.lastIndexOf(" ")

// Only honour the word boundary when it retains at least half the available
// budget. Otherwise a single early space (e.g. "a bcdefghijk") would discard
// nearly everything, so fall back to a hard character cut.
const useWordBoundary = lastSpace > 0 && lastSpace >= candidate.length / 2
const body = useWordBoundary ? candidate.slice(0, lastSpace) : candidate

return body.trimEnd() + ellipsis
}

export function slugify(str: string): string {
Expand All @@ -24,8 +45,8 @@ export function slugify(str: string): string {
.replace(/^-|-$/g, "")
}

// BUG: This doesn't handle multiple consecutive spaces
export function wordCount(str: string): number {
if (!str.trim()) return 0
return str.split(" ").length
const trimmed = str.trim()
if (!trimmed) return 0
return trimmed.split(/\s+/).length
}
29 changes: 21 additions & 8 deletions src/task-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,33 @@ export class TaskManager {
return true
}

// TODO: implement — remove a task by id, return true if removed, false if not found
remove(id: string): boolean {
throw new Error("not implemented")
return this.tasks.delete(id)
}

// TODO: implement — update title/description/priority of a task
// return true if updated, false if not found
update(id: string, changes: Partial<Pick<Task, "title" | "description" | "priority">>): boolean {
throw new Error("not implemented")
const task = this.tasks.get(id)
if (!task) return false
if (changes.title !== undefined) task.title = changes.title
if (changes.description !== undefined) task.description = changes.description
if (changes.priority !== undefined) task.priority = changes.priority
return true
}

// TODO: implement — return all tasks sorted by the given field
// priority sort order: high > medium > low
sortBy(field: "priority" | "createdAt" | "status"): Task[] {
throw new Error("not implemented")
const priorityOrder: Record<Priority, number> = { high: 0, medium: 1, low: 2 }
const statusOrder: Record<Status, number> = { in_progress: 0, pending: 1, completed: 2 }
const tasks = Array.from(this.tasks.values())

return tasks.sort((a, b) => {
switch (field) {
case "priority":
return priorityOrder[a.priority] - priorityOrder[b.priority]
case "status":
return statusOrder[a.status] - statusOrder[b.status]
case "createdAt":
return a.createdAt.getTime() - b.createdAt.getTime()
}
})
}
}
20 changes: 11 additions & 9 deletions src/validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,26 @@
/**
* Returns true if the string is a valid email address.
*
* BUG: the regex does not allow subdomains (e.g. user@mail.example.com fails)
* and rejects valid TLDs longer than 4 chars (e.g. .museum, .travel).
* Accepts subdomains (user@mail.example.com) and TLDs up to 63 characters
* (.museum, .travel). Rejects whitespace and a missing "@".
*
* The local part is deliberately permissive: RFC 5322 allows characters such
* as ' ! & ~ * { }, so narrowing it to an alphanumeric allowlist would reject
* legitimate addresses. This is a syntactic check only — deliverability can
* only be confirmed by sending mail.
*/
export function isEmail(value: string): boolean {
// BUG: too restrictive — missing subdomain support and long TLDs
return /^[^\s@]+@[^\s@]+\.[a-zA-Z]{2,4}$/.test(value)
return /^[^\s@]+@[^\s@]+\.[a-zA-Z]{2,63}$/.test(value)
}

/**
* Returns true if the string is a valid URL (http or https).
*
* BUG: rejects URLs with ports (e.g. http://localhost:3000)
* Returns true if the string is a valid URL restricted to the http and https
* schemes. Ports are permitted (e.g. http://localhost:3000).
*/
export function isUrl(value: string): boolean {
try {
const url = new URL(value)
// BUG: only allows http/https but also rejects valid port usage
return (url.protocol === "http:" || url.protocol === "https:") && url.port === ""
return url.protocol === "http:" || url.protocol === "https:"
} catch {
return false
}
Expand Down