fix: implement missing utilities and fix edge-case bugs - #279
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero - string-utils: fix wordCount whitespace handling, implement truncate - task-manager: implement remove/update/sortBy - date-utils: fix formatRelative off-by-one at day boundary - validator: widen isEmail TLD bound, accept URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. Final result: 60 pass / 0 fail,
tsc --noEmitclean. No test files modified, no dependencies added.Changes
src/calculator.ts—dividethrows on division by zero instead of returning a poisonedInfinity/NaN.src/string-utils.ts—wordCountsplits on\s+(collapses runs of spaces/tabs/newlines);truncateimplemented — reserves 3 chars for"...", cuts at a word boundary (falling back to a hard cut when the boundary would lose too much), never exceedsmaxLength, handlesmaxLength <= 3and negative values.src/task-manager.ts— implementedremove(returns boolean),update(returns false for unknown id, only overwrites explicitly-supplied fields), andsortBy(priority high→medium→low, createdAt oldest-first, status ordering) with exhaustive union handling.src/date-utils.ts—formatRelativeoff-by-one fixed: 36 hours now reads "2 days ago"; symmetric for future dates.src/validator.ts—isEmailTLD bound widened to 2–63 chars (accepts.museum);isUrlno longer rejects URLs with an explicit port (http://localhost:3000), keeps http/https scheme allowlist.Assumptions & notes
isEmail/isUrlare format checks only — not deliverability or SSRF/injection defences. IfisUrlis ever used to vet server-fetched URLs, loopback/private hosts (now accepted for the test) would need a call-site allowlist. Flagged for a follow-up rather than changed here.23.6h → "24 hours ago"boundary andsortByreturning liveTaskreferences were left as-is, out of scope for this fix.Test plan
bun test→ 60 pass / 0 failtsc --noEmit→ clean