Skip to content

conformance: do not require error for Final + ClassVar #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JelleZijlstra wants to merge 3 commits into
base: main
Choose a base branch
from
+229 −236
Open

conformance: do not require error for Final + ClassVar #2373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae7fbdf
conformance: do not require error for Final + ClassVar
JelleZijlstra Oct 20, 2026
6d3595a
feedback
JelleZijlstra Oct 20, 2026
bc8250a
regen
JelleZijlstra Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions conformance/results/mypy/classes_classvar.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,33 @@ Rejects `ClassVar` nested in `Annotated`.
Does not reject use of `ClassVar` in `TypeAlias` definition.
"""
output = """
classes_classvar.py:40: error: ClassVar[...] must have at most one type argument [valid-type]
classes_classvar.py:41: error: Invalid type: try using Literal[3] instead? [valid-type]
classes_classvar.py:42: error: Name "var" is not defined; did you mean "var1" or "vars"? [name-defined]
classes_classvar.py:54: error: Incompatible types in assignment (expression has type "dict[Never, Never]", variable has type "list[str]") [assignment]
classes_classvar.py:56: error: Variable should not be annotated with both ClassVar and Final [misc]
classes_classvar.py:57: error: Invalid type: ClassVar nested inside other type [valid-type]
classes_classvar.py:69: error: Invalid type: ClassVar nested inside other type [valid-type]
classes_classvar.py:39: error: ClassVar[...] must have at most one type argument [valid-type]
classes_classvar.py:40: error: Invalid type: try using Literal[3] instead? [valid-type]
classes_classvar.py:41: error: Name "var" is not defined; did you mean "var1" or "vars"? [name-defined]
classes_classvar.py:53: error: Incompatible types in assignment (expression has type "dict[Never, Never]", variable has type "list[str]") [assignment]
classes_classvar.py:55: error: Invalid type: ClassVar nested inside other type [valid-type]
classes_classvar.py:67: error: Invalid type: ClassVar nested inside other type [valid-type]
classes_classvar.py:69: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:70: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:71: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:72: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:73: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:75: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:79: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:80: error: ClassVar[...] can't be used inside a type alias [valid-type]
classes_classvar.py:89: error: ClassVar[...] can't be used inside a TypedDict [valid-type]
classes_classvar.py:94: error: ClassVar[...] can't be used inside a NamedTuple [valid-type]
classes_classvar.py:127: error: Cannot assign to class variable "stats" via instance [misc]
classes_classvar.py:146: error: All protocol members must have explicitly declared types [misc]
classes_classvar.py:156: error: Incompatible types in assignment (expression has type "ProtoAImpl", variable has type "ProtoA") [assignment]
classes_classvar.py:156: note: "ProtoAImpl" is missing following "ProtoA" protocol member:
classes_classvar.py:156: note: z
classes_classvar.py:156: note: Protocol member ProtoA.x expected class variable, got instance variable
classes_classvar.py:156: note: Protocol member ProtoA.y expected class variable, got instance variable
classes_classvar.py:77: error: ClassVar can only be used for assignments in class body [misc]
classes_classvar.py:78: error: ClassVar[...] can't be used inside a type alias [valid-type]
classes_classvar.py:87: error: ClassVar[...] can't be used inside a TypedDict [valid-type]
classes_classvar.py:92: error: ClassVar[...] can't be used inside a NamedTuple [valid-type]
classes_classvar.py:125: error: Cannot assign to class variable "stats" via instance [misc]
classes_classvar.py:144: error: All protocol members must have explicitly declared types [misc]
classes_classvar.py:154: error: Incompatible types in assignment (expression has type "ProtoAImpl", variable has type "ProtoA") [assignment]
classes_classvar.py:154: note: "ProtoAImpl" is missing following "ProtoA" protocol member:
classes_classvar.py:154: note: z
classes_classvar.py:154: note: Protocol member ProtoA.x expected class variable, got instance variable
classes_classvar.py:154: note: Protocol member ProtoA.y expected class variable, got instance variable
"""
conformance_automated = "Fail"
errors_diff = """
Line 46: Expected 1 errors
Line 47: Expected 1 errors
Line 48: Expected 1 errors
Line 49: Expected 1 errors
Line 69: Unexpected errors ['classes_classvar.py:69: error: Invalid type: ClassVar nested inside other type [valid-type]']
Line 146: Unexpected errors ['classes_classvar.py:146: error: All protocol members must have explicitly declared types [misc]']
Line 67: Unexpected errors ['classes_classvar.py:67: error: Invalid type: ClassVar nested inside other type [valid-type]']
Line 144: Unexpected errors ['classes_classvar.py:144: error: All protocol members must have explicitly declared types [misc]']
"""
44 changes: 22 additions & 22 deletions conformance/results/mypy/qualifiers_final_annotation.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,31 @@ qualifiers_final_annotation.py:71: error: Cannot assign to final name "RATE" [m
qualifiers_final_annotation.py:81: error: Cannot assign to final attribute "DEFAULT_ID" [misc]
qualifiers_final_annotation.py:94: error: Cannot assign to final name "BORDER_WIDTH" [misc]
qualifiers_final_annotation.py:96: error: Cannot assign to final name "__private" [misc]
qualifiers_final_annotation.py:107: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:108: error: Variable should not be annotated with both ClassVar and Final [misc]
qualifiers_final_annotation.py:118: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:121: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:131: error: Final[...] can't be used inside a TypedDict [valid-type]
qualifiers_final_annotation.py:136: error: Final[...] can't be used inside a NamedTuple [valid-type]
qualifiers_final_annotation.py:145: error: Invalid "NamedTuple()" field name [misc]
qualifiers_final_annotation.py:147: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:147: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:148: error: Unexpected keyword argument "a" for "N" [call-arg]
qualifiers_final_annotation.py:149: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:149: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:155: error: Cannot assign to final name "ID1" [misc]
qualifiers_final_annotation.py:159: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:161: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:166: error: Incompatible types in assignment (expression has type "TextIOWrapper[_WrappedBuffer]", variable has type "int") [assignment]
qualifiers_final_annotation.py:169: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:180: error: Cannot assign to final name "TEN" [misc]
qualifiers_final_annotation.py:184: error: Cannot assign to final name "PI" [misc]
qualifiers_final_annotation.py:108: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:109: error: Variable should not be annotated with both ClassVar and Final [misc]
qualifiers_final_annotation.py:119: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:122: error: Final can be only used as an outermost qualifier in a variable annotation [valid-type]
qualifiers_final_annotation.py:132: error: Final[...] can't be used inside a TypedDict [valid-type]
qualifiers_final_annotation.py:137: error: Final[...] can't be used inside a NamedTuple [valid-type]
qualifiers_final_annotation.py:146: error: Invalid "NamedTuple()" field name [misc]
qualifiers_final_annotation.py:148: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:148: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:149: error: Unexpected keyword argument "a" for "N" [call-arg]
qualifiers_final_annotation.py:150: error: Unexpected keyword argument "x" for "N" [call-arg]
qualifiers_final_annotation.py:150: error: Unexpected keyword argument "y" for "N" [call-arg]
qualifiers_final_annotation.py:156: error: Cannot assign to final name "ID1" [misc]
qualifiers_final_annotation.py:160: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:162: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:167: error: Incompatible types in assignment (expression has type "TextIOWrapper[_WrappedBuffer]", variable has type "int") [assignment]
qualifiers_final_annotation.py:170: error: Cannot assign to final name "x" [misc]
qualifiers_final_annotation.py:181: error: Cannot assign to final name "TEN" [misc]
qualifiers_final_annotation.py:185: error: Cannot assign to final name "PI" [misc]
"""
conformance_automated = "Fail"
errors_diff = """
Line 163: Expected 1 errors
Line 164: Expected 1 errors
Line 59: Unexpected errors ['qualifiers_final_annotation.py:59: error: Cannot assign to final attribute "ID6" [misc]']
Line 96: Unexpected errors ['qualifiers_final_annotation.py:96: error: Cannot assign to final name "__private" [misc]']
Line 145: Unexpected errors ['qualifiers_final_annotation.py:145: error: Invalid "NamedTuple()" field name [misc]']
Line 147: Unexpected errors ['qualifiers_final_annotation.py:147: error: Unexpected keyword argument "x" for "N" [call-arg]', 'qualifiers_final_annotation.py:147: error: Unexpected keyword argument "y" for "N" [call-arg]']
Line 146: Unexpected errors ['qualifiers_final_annotation.py:146: error: Invalid "NamedTuple()" field name [misc]']
Line 148: Unexpected errors ['qualifiers_final_annotation.py:148: error: Unexpected keyword argument "x" for "N" [call-arg]', 'qualifiers_final_annotation.py:148: error: Unexpected keyword argument "y" for "N" [call-arg]']
"""
33 changes: 16 additions & 17 deletions conformance/results/pycroscope/classes_classvar.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,22 @@ conformance_automated = "Pass"
errors_diff = """
"""
output = """
./classes_classvar.py:40:10: Invalid type annotation (<class 'int'>, <class 'str'>) [invalid_annotation]
./classes_classvar.py:41:10: Invalid type annotation 3 [invalid_annotation]
./classes_classvar.py:42:13: Undefined name: var [undefined_name]
./classes_classvar.py:39:10: Invalid type annotation (<class 'int'>, <class 'str'>) [invalid_annotation]
./classes_classvar.py:40:10: Invalid type annotation 3 [invalid_annotation]
./classes_classvar.py:41:13: Undefined name: var [undefined_name]
./classes_classvar.py:46:10: ClassVar type cannot include type parameters [classvar_type_parameters]
./classes_classvar.py:47:10: ClassVar type cannot include type parameters [classvar_type_parameters]
./classes_classvar.py:48:10: ClassVar type cannot include type parameters [classvar_type_parameters]
./classes_classvar.py:49:10: ClassVar type cannot include type parameters [classvar_type_parameters]
./classes_classvar.py:54:4: Incompatible assignment: expected list[str], got Literal[{}] [incompatible_assignment]
./classes_classvar.py:56:10: Final cannot be combined with ClassVar [invalid_qualifier]
./classes_classvar.py:57:11: Unrecognized annotation typing.ClassVar[<class 'int'>] [invalid_annotation]
./classes_classvar.py:71:25: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:72:11: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:73:17: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:75:25: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:79:7: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:80:19: ClassVar cannot be used in type aliases [invalid_qualifier]
./classes_classvar.py:89:7: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:94:7: ClassVar cannot be used for NamedTuple fields [invalid_qualifier]
./classes_classvar.py:127:0: Cannot assign to class variable 'stats' via instance [incompatible_assignment]
./classes_classvar.py:156:0: Incompatible assignment: expected ./classes_classvar.py.ProtoA, got ./classes_classvar.py.ProtoAImpl [incompatible_assignment]
./classes_classvar.py:53:4: Incompatible assignment: expected list[str], got Literal[{}] [incompatible_assignment]
./classes_classvar.py:55:11: Unrecognized annotation typing.ClassVar[<class 'int'>] [invalid_annotation]
./classes_classvar.py:69:25: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:70:11: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:71:17: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:73:25: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:77:7: ClassVar can only be used for assignments in class body [invalid_qualifier]
./classes_classvar.py:78:19: ClassVar cannot be used in type aliases [invalid_qualifier]
./classes_classvar.py:87:7: Unexpected ClassVar annotation [invalid_qualifier]
./classes_classvar.py:92:7: ClassVar cannot be used for NamedTuple fields [invalid_qualifier]
./classes_classvar.py:125:0: Cannot assign to class variable 'stats' via instance [incompatible_assignment]
./classes_classvar.py:154:0: Incompatible assignment: expected ./classes_classvar.py.ProtoA, got ./classes_classvar.py.ProtoAImpl [incompatible_assignment]
"""
32 changes: 16 additions & 16 deletions conformance/results/pycroscope/qualifiers_final_annotation.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@ output = """
./qualifiers_final_annotation.py:71:0: Cannot assign to final name RATE [incompatible_assignment]
./qualifiers_final_annotation.py:81:0: Cannot assign to final name DEFAULT_ID [incompatible_assignment]
./qualifiers_final_annotation.py:94:4: Cannot override final attribute BORDER_WIDTH [incompatible_override]
./qualifiers_final_annotation.py:107:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:108:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:118:3: Unrecognized annotation typing.Final[<class 'int'>] [invalid_annotation]
./qualifiers_final_annotation.py:121:13: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:131:7: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:136:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:148:0: In call to pycroscope.signature.N: Missing required argument 'x' [incompatible_call]
./qualifiers_final_annotation.py:149:4: Incompatible argument type for x: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:149:10: Incompatible argument type for y: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:155:4: Cannot assign to final name ID1 [incompatible_assignment]
./qualifiers_final_annotation.py:159:4: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:161:9: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:163:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:166:29: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:169:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:180:0: Cannot assign to final name TEN [incompatible_assignment]
./qualifiers_final_annotation.py:184:0: Cannot assign to final name PI [incompatible_assignment]
./qualifiers_final_annotation.py:109:12: Final cannot be combined with ClassVar [invalid_qualifier]
./qualifiers_final_annotation.py:119:3: Unrecognized annotation typing.Final[<class 'int'>] [invalid_annotation]
./qualifiers_final_annotation.py:122:13: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:132:7: Unexpected Final annotation [invalid_qualifier]
./qualifiers_final_annotation.py:137:4: Final class attributes without initializers must be assigned in __init__ [invalid_qualifier]
./qualifiers_final_annotation.py:149:0: In call to pycroscope.signature.N: Missing required argument 'x' [incompatible_call]
./qualifiers_final_annotation.py:150:4: Incompatible argument type for x: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:150:10: Incompatible argument type for y: expected int but got Literal[''] [incompatible_argument]
./qualifiers_final_annotation.py:156:4: Cannot assign to final name ID1 [incompatible_assignment]
./qualifiers_final_annotation.py:160:4: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:162:9: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:164:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:167:29: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:170:8: Cannot assign to final name x [incompatible_assignment]
./qualifiers_final_annotation.py:181:0: Cannot assign to final name TEN [incompatible_assignment]
./qualifiers_final_annotation.py:185:0: Cannot assign to final name PI [incompatible_assignment]
"""
Loading
Loading