Repository navigation
conformance: do not require error for Final + ClassVar - #2373
Open
JelleZijlstra wants to merge 3 commits into
Open
JelleZijlstra wants to merge 3 commits into
JelleZijlstra wants to merge 3 commits into
Conversation
And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation already tests it in a more isolated way. Fixes python#2371.
jorenham
approved these changes
Oct 20, 2026
jorenham
left a comment
jorenham
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense; thanks :)
carljm
approved these changes
Oct 20, 2026
carljm
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation
already tests it in a more isolated way.
Fixes #2371.