gh-152190: Fix memory checking failure in test_strip_removed_large_file_with_dd_no_sig#152203
Open
danny0838 wants to merge 3 commits into
Open
gh-152190: Fix memory checking failure in test_strip_removed_large_file_with_dd_no_sig#152203danny0838 wants to merge 3 commits into
test_strip_removed_large_file_with_dd_no_sig#152203danny0838 wants to merge 3 commits into
Conversation
StanFromIreland
changed the title
test_strip_removed_large_file_with_dd_no_sigtest_strip_removed_large_file_with_dd_no_sig
danny0838
force-pushed
the
gh-51067-6
branch
3 times, most recently
from
c98f30e to
34a009b
Compare
…arge_file_with_dd_no_sig` Remove the overly restrictive `allowed_memory` override (200 KiB) in `test_strip_removed_large_file_with_dd_no_sig` to prevent a memory checking failure.
Introduce the `assert_memory_usage` context manager to narrow the scope of tracemalloc tracking down exclusively to the file-repacking phase. This prevents previous file-writing side effects from interfering with the baseline, improves tracing accuracy, and eliminates redundant inner sub-function wrappers.
Contributor
Author
|
It seems that a dynamic memory threshold cannot be easily calculated. Keep the original empirical threshold and revise the comment to be more clear. Additionally, introduce the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the overly restrictive
allowed_memoryoverride (200 KiB) intest_strip_removed_large_file_with_dd_no_sigto prevent a memory checking failure.Additionally, redefine the global baseline allowed memory as a multiplier of the default buffer size instead of a static 10 MiB constant. This ensures the threshold scales safely relative to the underlying platform.
test_zipfile64.[...].test_strip_removed_large_file_with_dd_no_sigfails on BigMem runs #152190