gh-151814: Add test for TextIOWrapper.write unbounded memory growth from repeated writes#152244
Open
cmaloney wants to merge 1 commit into
Open
gh-151814: Add test for TextIOWrapper.write unbounded memory growth from repeated writes#152244cmaloney wants to merge 1 commit into
cmaloney wants to merge 1 commit into
Conversation
…owth from repeated writes Use tracemalloc to measure memory usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use tracemalloc to measure memory usage.
Fails before GH-151817, passes after. Validated by changing condition between
> 0and>= 0and rebuilding + runningmake && ./python -m test test_io.test_textio -m "test_write_empty_no_memory_growth".cpython/Modules/_io/textio.c
Line 1823 in 908f438
Inspired by the report memory usage helper in GH-152203 (If it gets more use should probably move to
test.support).cc: @StanFromIreland