Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dev

**Bugfixes**

-
- Recalculate the body length when serializing an ExtensionFrame.

6.1.0 (2025-01-22)
------------------
Expand Down
2 changes: 2 additions & 0 deletions src/hyperframe/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,8 @@ def serialize(self) -> bytes:
user code: it exists only as a helper method if frames need to be
reconstituted.
"""
self.body_len = len(self.body)

# Build the frame header.
# First, get the flags.
flags = self.flag_byte
Expand Down
13 changes: 13 additions & 0 deletions tests/test_frames.py
Original file line number Diff line number Diff line change
Expand Up @@ -995,3 +995,16 @@ class TestExtensionFrame:
def test_repr(self):
f = ExtensionFrame(0xFF, 1, 42, b'hello')
assert repr(f).endswith("type=255, flag_byte=42, body=<hex:68656c6c6f>")


@pytest.mark.parametrize('body', [b'', b'hello', b'x' * 256])
def test_extension_frame_serialized_body_length(body):
frame = ExtensionFrame(0xFF, 1, 42, body)
decoded = decode_frame(frame.serialize())
assert decoded.body == body
assert decoded.body_len == len(body)
assert decoded.flag_byte == 42
frame.body = b'replacement'
decoded = decode_frame(frame.serialize())
assert decoded.body == b'replacement'
assert decoded.body_len == len(frame.body)