Recalculate ExtensionFrame body length when serializing - #169
Open
vitalivo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing an ExtensionFrame constructed with
body=b"hello"writes a zero-length header followed by five bytes. Changing the body of an already parsed frame similarly retains the old length.Recalculate
body_lenduring serialization, as the base Frame serializer does. The tests cover empty, short, and 256-byte initial bodies, then replace each body and round-trip the resulting wire frame.All three regression cases fail before the fix. Full Python 3.12 suite: 151 passed, 100% branch coverage. Ruff and strict mypy pass. Includes a changelog entry.