Repository navigation
Conversation
## Summary `unthreaded_entries` in `scripts/pr_review.py` counted every distinct thread id across every link of every open entry. An entry whose title anchor is a thread on the pull request, but which also carries a back-reference to an id no fetched thread carries, therefore added one to `FINDINGS WITH NO THREAD` although the entry has a thread. - `open_entry_ids` now reads each entry by its first link, its title's own anchor, as `carried_open_threads` already does. A title anchor past the hundred threads read, and an entry with no recognized link, still overstate as documented. - The `FINDINGS WITH NO THREAD` wording now says "no title link" to match the per-entry count. That covers the digest block, the module usage text, `scripts/README.md`, and the `pr-review-conduct` Merge Gate item. The skill's generated trees were regenerated with `scripts/build_dist.py`. - Two tests: a threaded title beside an unread back-reference reads 0, and an unthreaded title beside a threaded back-reference still reads 1. The first fails against the base. ## Verification - `python3 -m unittest tests.test_pr_review`: 665 tests OK. - ruff format/check, mypy, `spec/validate.py`, `build_dist.py --check`, and both prose_lint diff runs are clean. - A local-strict-review pass ran over three rounds, with 1, 2, and then 0 findings, and it is recorded. Closes on promotion: #2621 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Open findings are now counted as threaded only when their title links to a pull-request thread. Other links in the entry no longer affect whether it is reported as unthreaded. * **Tests** * Added coverage for title links and back-references when identifying unthreaded findings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
0 open findings
What changed in this PR
Promotes the title-anchor fix for counting unthreaded findings and synchronizes related tests, documentation, and generated skill files.
Changes:
- Counts entries by their title anchor.
- Adds regression coverage for back-references.
- Updates documentation and generated skill content.
| File | Summary |
|---|---|
tests/test_pr_review.py |
Adds regression coverage. |
scripts/README.md |
Documents title-link behavior. |
scripts/pr_review.py |
Uses title anchors for counting. |
.github/skills/pr-review-conduct/SKILL.md |
Updates generated guidance. |
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md |
Updates generated guidance. |
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct |
Updates the source digest. |
.agents/skills/pr-review-conduct/SKILL.md |
Updates canonical guidance. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 59.34% 59.34%
=======================================
Files 16 16
Lines 8282 8282
=======================================
Hits 4915 4915
Misses 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
Promotes the one change develop holds over main:
pr_review.py'sunthreaded_entriesreads each open entry by its title anchor rather than by every link it carries, so a back-reference beside a threaded title no longer counts as a finding with no thread. TheFINDINGS WITH NO THREADwording in the digest, the usage text,scripts/README.md, andpr-review-conductnow says "title link" to match (#2641).Fixes #2621
🤖 Generated with Claude Code