Skip to content

fix SVG preserveAspectRatio="none" handling for <symbol>/<use> #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danyccsf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix SVG preserveAspectRatio="none" handling for <symbol>/<use> #9261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5928cf4
fix SVG preserveAspectRatio none handling
Danyccsf Oct 7, 2026
691e886
Merge branch 'main' into fix-svg-preserve-aspect-ratio-none
Danyccsf Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/shape/svg/svg_import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,12 +699,26 @@ export function SVGImportAddon(p5, fn, lifecycles) {
? this.num(node, "height")
: (referenced.height?.baseVal?.value || vb.height);

const scale = Math.min(w / vb.width, h / vb.height); // default: xMidYMid meet
this.tStack.current.translateSelf(
(w - vb.width * scale) / 2 - vb.x * scale,
(h - vb.height * scale) / 2 - vb.y * scale
);
this.tStack.current.scaleSelf(scale, scale);
const preserveAspectRatio = referenced.getAttribute("preserveAspectRatio");

if (preserveAspectRatio?.trim() === "none") {
const scaleX = w / vb.width;
const scaleY = h / vb.height;

this.tStack.current.translateSelf(
-vb.x * scaleX,
-vb.y * scaleY
);
this.tStack.current.scaleSelf(scaleX, scaleY);
} else {
const scale = Math.min(w / vb.width, h / vb.height); // default: xMidYMid meet

this.tStack.current.translateSelf(
(w - vb.width * scale) / 2 - vb.x * scale,
(h - vb.height * scale) / 2 - vb.y * scale
);
this.tStack.current.scaleSelf(scale, scale);
}
}
this.visit(referenced);
});
Expand Down Expand Up @@ -1623,4 +1637,4 @@ export function SVGImportAddon(p5, fn, lifecycles) {

if (typeof p5 !== 'undefined') {
p5.registerAddon(SVGImportAddon);
}
}
37 changes: 37 additions & 0 deletions test/unit/svg/svg_import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,43 @@ suite('<defs> and <use> elements', function () {
});
});

test('use respects preserveAspectRatio=none', function () {
const record = createSVG(`
<svg xmlns="http://www.w3.org/2000/svg">
<defs>
<symbol id="stretch" viewBox="0 0 100 100" preserveAspectRatio="none">
<rect x="0" y="0" width="100" height="100" />
</symbol>
</defs>
<use href="#stretch" width="200" height="100" />
</svg>
`);
const scope = firstChild(record);
const node = scope.children[0];
assert.closeTo(node.state.transform.a, 2, 0.001);
assert.closeTo(node.state.transform.d, 1, 0.001);
});

test('use with preserveAspectRatio=none accounts for viewBox origin', function () {
const record = createSVG(`
<svg xmlns="http://www.w3.org/2000/svg">
<defs>
<symbol id="stretch-offset" viewBox="10 20 100 100" preserveAspectRatio="none">
<rect x="10" y="20" width="100" height="100" />
</symbol>
</defs>
<use href="#stretch-offset" width="200" height="100" />
</svg>
`);
const scope = firstChild(record);
const node = scope.children[0];

assert.closeTo(node.state.transform.a, 2, 0.001);
assert.closeTo(node.state.transform.d, 1, 0.001);
assert.closeTo(node.state.transform.e, -20, 0.001);
assert.closeTo(node.state.transform.f, -20, 0.001);
});

test('handles missing references gracefully', function () {
const record = createSVG(`
<svg xmlns="http://www.w3.org/2000/svg">
Expand Down
Loading