Repository navigation
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: 691e886 Previous deploymentsThis is an automated message. |
davepagurek
left a comment
There was a problem hiding this comment.
This is looking good! Do you think we could add some visual tests so it's easier to verify the output?
I also was looking at https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/preserveAspectRatio to see what other options there are than none. Do you have a sense of what it might take to fully cover this attribute and whether that's worth adding?
Thanks, Dave! I appreciate the feedback. I'll look into the existing visual testing setup and add appropriate visual coverage for this case. I'll also review the other preserveAspectRatio options and assess the scope of supporting them, so we can decide whether they belong in this PR or would be better handled separately. I'll follow up with my findings! |
Resolves #9257
Changes:
preserveAspectRatio="none"when a<use>element references a<symbol>with aviewBox.xMidYMid meetscaling in this case.viewBoxorigins when applying the transform.xMidYMid meetbehavior for other cases.viewBoxorigin.Screenshots of the change:
N/A — this change is covered by SVG importer unit tests.
PR Checklist
npm run lintpasses