Skip to content

Grant machinist RBAC to create image pull secrets #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcopiraccini merged 2 commits into from
Jul 10, 2026
Merged

Grant machinist RBAC to create image pull secrets #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a3337
RBAC to machinist to create K8s secrets
marcopiraccini Jul 10, 2026
984035a
RBAC to machinist to create K8s secrets
marcopiraccini Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions chart/templates/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,11 @@ rules:
- services
verbs:
- delete
{{- if .Values.services.icc.features.skew_protection.manage_mode }}
# Skew protection manage mode (opt-in): ICC creates versioned Deployments and
# Services. Only granted when features.skew_protection.manage_mode is true;
# observe/advise modes never need it (advise applies via the external actor).
{{- if .Values.services.icc.features.deployer.enable }}
# ICC deployer (opt-in): the deploy API creates the workload -- versioned
# Deployments and Services -- so the pod can boot and register. Independent of
# skew protection. Only granted when features.deployer.enable is true;
# observe-only installs (the customer's CI creates the workload) never need it.
- apiGroups:
- ""
- apps
Expand All @@ -144,6 +145,17 @@ rules:
- create
- update
- patch
# Image-pull secrets: the deploy API creates a dockerconfigjson Secret from the
# registry credentials in the request so a private image can be pulled. Applied
# via server-side apply, so only create + patch are needed -- never get (which
# would expose secret contents) or update/delete.
- apiGroups:
- ""
resources:
- secrets
verbs:
- create
- patch
{{- end }}
# Gateway API - for skew protection (opt-in)
- apiGroups:
Expand Down
3 changes: 2 additions & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ services:
enable: false
scaler_trends_learning:
enable: false
deployer:
enable: false # ICC deployer creates workloads via the deploy API (Deployments/Services/pull Secrets). Off = observe-only, least privilege
skew_protection:
enable: false
manage_mode: false # Grant ICC create/update/patch on Deployments+Services (manage-mode deploys). Off = least privilege
auto_cleanup: false # Delete expired Deployment and Service resources
http_grace_period_ms: 1800000 # Min time to keep HTTP version draining (30 min)
http_max_alive_ms: 86400000 # Hard deadline for HTTP versions (24h)
Expand Down
Loading