Grant machinist RBAC to create image pull secrets#62
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
marked this pull request as ready for review
July 10, 2026 12:26
marcopiraccini
changed the title
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployer API in icc-3 creates a dockerconfigjson Secret from the registry credentials in a deploy request so a private image can be pulled, and machinist applies it to the target namespace. This grants the plt-pod-manager ServiceAccount the permission to do that.
Adds
secrets: [create, patch]to the plt-pod-manager ClusterRole, next to the existing workload-create permissions (gated onfeatures.skew_protection.manage_mode). Least privilege: the Secret is written with server-side apply, so only create and patch are needed -- neverget(which would expose secret contents), nor update or delete.Requires platformatic/machinist#74 and is required by platformatic/icc-3#909.