Repository navigation
feat: edit saved annotations from manager - #73
Merged
Merged
Conversation
Let users correct saved feedback without recapturing the selection or changing its provenance and ordering. Reuse the existing comment editor. Keep active records when they differ from an archive snapshot, so an archive action in another pane cannot delete a successfully saved edit. Reject stale saves and keep their drafts open so two manager panes cannot silently overwrite each other's feedback.
backnotprop
force-pushed
the
edit-saved-annotations
branch
from
October 23, 2026 18:27
86ee727 to
545a247
Compare
The manager now reloads saved annotations before it opens the editor, so an edit never starts from a stale copy. If the annotation was removed in another pane, it says so and does not open the editor. The clear confirmation now matches the footer and says D, not Shift+D. Empty-store test asserts use assert_eq so clippy 1.99 passes. refs plannotator#68
backnotprop
force-pushed
the
edit-saved-annotations
branch
from
October 23, 2026 18:30
545a247 to
f5e1367
Compare
Contributor
|
Thanks @graemefolk, merged. Two small tweaks on top: the manager reloads before opening the editor so an edit never starts from a stale copy, and the clear prompt now says "Press D again" to match the footer. |
This was referenced Oct 23, 2026
backnotprop
added a commit
that referenced
this pull request
Oct 23, 2026
Contributor
|
@graemefolk this is now live in plugin 0.9.3; update the plugin to get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68.
You can now press
ein the manager to edit a saved comment.Ctrl+Ssaves andEsccancels, without changing the selected text or where it came from.A save from another pane won't be overwritten, and archiving won't lose an edit.
Checked with all 123 Rust tests and the terminal test suite (150 screens).