Repository navigation
release: ship the annotation editor in helper 0.2.2; plugin 0.9.3 - #79
Merged
Merged
Conversation
#73 added `e` to edit a saved annotation in the manager, but the change lives in rust/, and installs download the helper pinned by herdr-annotate.version. rust-lite-v0.2.1 was built before #73, so the new manifest description and README key were live while `e` did nothing. Bumping the helper to 0.2.2 lets a rust-lite-v0.2.2 release carry the editor, and the new pin makes existing installs fetch it.
Installs fetch the released helper, so a rust/ change that keeps herdr-annotate.version unchanged never reaches users (#74, #73). The new helper-version job diffs rust/ against rust-lite-v<version> and fails when they differ. A version with no tag yet counts as bumped, so release branches pass before their tag is pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#73 added
eto edit a saved annotation in the manager, but the code lives inrust/, and installs download the pinned helper.rust-lite-v0.2.1was built before #73, so users see the new manifest description and README key whileedoes nothing.This bumps the helper to 0.2.2 so a
rust-lite-v0.2.2release carries the editor, and bumps the plugin to 0.9.3 in all four manifests. The new pin makes existing installs fetch the new binary.It also adds a
helper-versionjob to rust-lite-ci. The job fails whenrust/differs fromrust-lite-v$(cat herdr-annotate.version). A version with no tag yet counts as bumped, so release branches pass before their tag exists.The
rust-lite-v0.2.2tag goes on this PR's head, and the release must publish before this merges.