Repository navigation
Build and publish a Docker image - #25
Merged
Merged
Conversation
TIN never inserts empty documents into the index, which means they don't count toward the number of documents or average doc length for BM25 calculations. Lead now matches that behavior.
Only the main branch can publish. The PR will build the image. Once the PR is merged, main will build the image again and push it to dockerhub.
No need to do {pg17, pg18} x {arm64,x86-64} for both CI and Docker. Just
run the tests as the first step in the Docker builds.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a debug build. I've integrated the unit test run into the Docker image builds so we don't run
cargo pgrx installand download a zillion crates eight times -- just four.Only the
mainbranch can publish to Docker Hub. So I'll open this PR, merge it, and see if the push actually works on the merge commit tomain.