Skip to content

fix(mobile): keep file rows above search toolbar #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzocorallo wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(mobile): keep file rows above search toolbar #5149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/mobile/src/features/files/FileTreeBrowser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const FileTreeRow = memo(function FileTreeRow(props: {
});

export function FileTreeBrowser(props: {
readonly bottomContentPadding?: number;
readonly entries: ReadonlyArray<ProjectEntry>;
readonly error: string | null;
readonly isPending: boolean;
Expand Down Expand Up @@ -255,7 +256,10 @@ export function FileTreeBrowser(props: {
maxToRenderPerBatch={FILE_TREE_RENDER_BATCH_SIZE}
updateCellsBatchingPeriod={16}
windowSize={5}
contentContainerStyle={{ paddingTop: 8, paddingBottom: 8 }}
contentContainerStyle={{
paddingTop: 8,
paddingBottom: props.bottomContentPadding ?? 8,
}}
refreshControl={<RefreshControl refreshing={props.isPending} onRefresh={props.onRefresh} />}
renderItem={renderItem}
ListEmptyComponent={
Expand Down
4 changes: 4 additions & 0 deletions apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,10 @@ export function ThreadFilesTreeScreen(props: ThreadFilesRouteScreenProps) {
</>
)}
<FileTreeBrowser
bottomContentPadding={
// Matches the h-28 toolbar fade: 28 spacing units at 4 points each.
isAndroid ? undefined : 112
}
entries={entriesData?.entries ?? []}
error={entriesQuery.error}
isPending={entriesQuery.isPending}
Expand Down
Loading