Skip to content

fix(mobile): keep file rows above search toolbar - #5149

Open
lorenzocorallo wants to merge 1 commit into
pingdotgg:mainfrom
lorenzocorallo:fix/mobile-thread-files-bottom-spacing
Open

fix(mobile): keep file rows above search toolbar#5149
lorenzocorallo wants to merge 1 commit into
pingdotgg:mainfrom
lorenzocorallo:fix/mobile-thread-files-bottom-spacing

Conversation

@lorenzocorallo

@lorenzocorallo lorenzocorallo commented Jul 31, 2026

Copy link
Copy Markdown

What Changed

  • Allow the shared file tree to accept route-specific bottom content padding.
  • Reserve 112 points below the iOS thread file list, matching the existing toolbar fade.
  • Leave the Android in-flow search layout and iPad file navigator unchanged.

Why

With enough files in a thread, the final row could scroll underneath the floating iOS search toolbar and become untappable. The added scrollable footer lets the final row settle fully above the toolbar.

UI Changes

Before: the final file row could remain underneath the floating iOS search toolbar at the end of the list.

After: the final row scrolls above a toolbar-sized empty footer and remains tappable.

Before/after screenshots are unavailable because the current Linux test host has no iOS simulator; Android uses an in-flow search field and does not reproduce the overlap.

Verification

  • vp fmt --check apps/mobile/src/features/files/FileTreeBrowser.tsx apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx
  • vp lint apps/mobile/src/features/files/FileTreeBrowser.tsx apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx --report-unused-disable-directives
  • vp run --filter @t3tools/mobile typecheck
  • vp test run apps/mobile/src/features/files/fileTree.test.ts (5 tests passed)

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for UI changes (iOS simulator unavailable on this host)
  • Video is not applicable; this change has no animation or timing behavior

Created with gpt-5.6-sol via the Codex harness in T3 Code.


Note

Low Risk
Localized scroll padding for one iOS screen; no auth, data, or shared business-logic changes.

Overview
Fixes the thread Files list on iOS where the last file row could sit under the floating search toolbar and stay untappable after scrolling.

FileTreeBrowser now accepts optional bottomContentPadding on its FlatList (default 8). ThreadFilesTreeScreen passes 112 on non-Android platforms to match the existing h-28 toolbar fade height. Android (in-flow search) and other FileTreeBrowser callers such as the iPad file navigator are unchanged.

Reviewed by Cursor Bugbot for commit 009270c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Keep file rows above search toolbar by adding bottom padding to FileTreeBrowser

Adds a bottomContentPadding prop to FileTreeBrowser, defaulting to 8 when not set. In ThreadFilesRouteScreen, this prop is set to 112 on non-Android platforms so list content scrolls clear of the search toolbar. Android behavior is unchanged.

Macroscope summarized 009270c.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 353d67d1-c2c1-49ff-ab05-8330d4d2a717

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 31, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 31, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 009270c

Simple UI layout fix that adds bottom padding to prevent file rows from being hidden behind the search toolbar on iOS. The change is minimal and only affects styling/spacing.

You can customize Macroscope's approvability policy. Learn more.

@lorenzocorallo
lorenzocorallo force-pushed the fix/mobile-thread-files-bottom-spacing branch from 5d88821 to fc8b566 Compare July 31, 2026 22:02
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 31, 2026 22:02

Dismissing prior approval to re-evaluate fc8b566

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fc8b566. Configure here.

Comment thread apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx Outdated
@lorenzocorallo
lorenzocorallo force-pushed the fix/mobile-thread-files-bottom-spacing branch from fc8b566 to 009270c Compare July 31, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant