fix(mobile): keep file rows above search toolbar - #5149
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 009270c Simple UI layout fix that adds bottom padding to prevent file rows from being hidden behind the search toolbar on iOS. The change is minimal and only affects styling/spacing. You can customize Macroscope's approvability policy. Learn more. |
5d88821 to
fc8b566
Compare
Dismissing prior approval to re-evaluate fc8b566
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fc8b566. Configure here.
fc8b566 to
009270c
Compare

What Changed
Why
With enough files in a thread, the final row could scroll underneath the floating iOS search toolbar and become untappable. The added scrollable footer lets the final row settle fully above the toolbar.
UI Changes
Before: the final file row could remain underneath the floating iOS search toolbar at the end of the list.
After: the final row scrolls above a toolbar-sized empty footer and remains tappable.
Before/after screenshots are unavailable because the current Linux test host has no iOS simulator; Android uses an in-flow search field and does not reproduce the overlap.
Verification
vp fmt --check apps/mobile/src/features/files/FileTreeBrowser.tsx apps/mobile/src/features/files/ThreadFilesRouteScreen.tsxvp lint apps/mobile/src/features/files/FileTreeBrowser.tsx apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx --report-unused-disable-directivesvp run --filter @t3tools/mobile typecheckvp test run apps/mobile/src/features/files/fileTree.test.ts(5 tests passed)Checklist
Created with gpt-5.6-sol via the Codex harness in T3 Code.
Note
Low Risk
Localized scroll padding for one iOS screen; no auth, data, or shared business-logic changes.
Overview
Fixes the thread Files list on iOS where the last file row could sit under the floating search toolbar and stay untappable after scrolling.
FileTreeBrowsernow accepts optionalbottomContentPaddingon itsFlatList(default 8).ThreadFilesTreeScreenpasses 112 on non-Android platforms to match the existingh-28toolbar fade height. Android (in-flow search) and otherFileTreeBrowsercallers such as the iPad file navigator are unchanged.Reviewed by Cursor Bugbot for commit 009270c. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep file rows above search toolbar by adding bottom padding to FileTreeBrowser
Adds a
bottomContentPaddingprop toFileTreeBrowser, defaulting to 8 when not set. InThreadFilesRouteScreen, this prop is set to 112 on non-Android platforms so list content scrolls clear of the search toolbar. Android behavior is unchanged.Macroscope summarized 009270c.