Repository navigation
feat(web): add workspace panes and transitions - #28845
maria-rcks wants to merge 45 commits into
Conversation
|
Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting). This review would cost an estimated $36.47, which exceeds your per-review limit of $15.00. The top 3 files driving up this estimate:
Tip To get this pull request reviewed, you can:
|
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This adds workspace panes and transitions while changing familiar default shortcuts, including Mod+D, Mod+W, and Mod+T. Human review is required for those product-default changes and their migration into existing shortcut configurations. Needs human approval because:
Review your spending limits in Billing settings, or comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
f6f00d4 to
b653b87
Compare
b653b87 to
f0dd9b6
Compare
f0dd9b6 to
ba88740
Compare
ba88740 to
91b0851
Compare
91b0851 to
814c2e3
Compare
Part 6 of 6 of the T3 Code redesign. Chats, files, terminals and the browser open as panes in a horizontally scrolling workspace instead of fixed side panels.
Needs approval: Theo for
vite.config.ts(lint ceilings only); Theo or Julius forpackages/contracts(ipc, keybindings, server, settings).Stack
Do not merge: this stack still needs review. Each PR targets the one below it.
1-primitives-shell2-composer-timeline3-panels-pages4-settings-setup5-voice6-workspace-panes(this PR)Evidence
Captured against base
5ba6597504b681819ff657e5e0808c54b37edb42and headf6f00d4f4fe175e66f5d7fc6018ace6a1c841ca3, using separate seeded worktrees and the same replay scenarios at 1280 × 720. Dark mode unless labeled light. No code, PR, or branch changes.Chat, terminal, and the same server/package.json file: the fixed right panel becomes an independent workspace column.
Browser: the same example.com page remains usable beside the chat and terminal, with the file and browser represented as workspace tabs.
Workspace tab strip: overflow scrolling and active filename reveal were exercised with package.json, README.md, tsconfig.json, vite.config.ts, and the browser. Measured 466 px of tab content in a 326 px viewport; selecting vite.config.ts revealed its filename. Native drag reordered vite.config.ts before README.md and before tsconfig.json in separate passes. The base has no workspace pane tab strip; its fixed panel baseline is shown above.
Restore a closed chat: Ctrl+Shift+T reopened Replay: todo-list with its existing conversation. Closing and restoring a browser also retained its URL and page. Chat-tab restore has no equivalent on the base.
Layout introduction and guided tour are new on this layer. Opened Show me, advanced through all five steps, entered the overview lesson, and finished back in the workspace.
Usage adopts the floating settings shell. Both refs show the same real provider error, with matching selections, in dark mode.
Usage, matching light-mode pair.
Nine-second recording: native tab drag, horizontal column scrolling, closing the chat, and restoring it. Reviewed the exported sequence, then played the uploaded video to completion and checked seeking.
Findings and limits:
Codex could not read usage (JSON-RPC -32600). No usage data was fabricated.Verification
Every layer, on its own and rebased on main fa31b66, passes CI's commands on Blacksmith:
vp run knip:check, both GraphQL codegen checks,vp check,vp run typecheck,vp run --filter @t3tools/web test(unit and browser), and the Test job. Layer 6 also passesvp run --filter @t3tools/desktop test.Done with Claude Code (Opus 5.5) and Codex (gpt-6.1-sol high) children in T3 Code.
🤖 Generated with Claude Code