Repository navigation
feat(server): let custom Claude models opt into 1M context #28024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chisewaguri
wants to merge
8
commits into
pingdotgg:main
Choose a base branch
from
chisewaguri:fix/claude-custom-model-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+642
−79
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
43c1c27
feat(server): let custom Claude models opt into 1M context
chisewaguri 924fde8
Merge branch 'main' into fix/claude-custom-model-options
chisewaguri 3a19fd0
fix(server): preserve 1M context in Claude subagent selections
chisewaguri a1fd17a
fix(server): retain inherited Claude subagent options
chisewaguri 42eec11
fix(clients): compact thinking status in composer labels
chisewaguri 284dd5e
fix(server): honor Claude settings for subagent model defaults
chisewaguri f0a124d
fix(clients): show enabled thinking without an effort selector
chisewaguri f95a0d7
Merge branch 'main' into fix/claude-custom-model-options
chisewaguri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
343 changes: 326 additions & 17 deletions
343
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
Large diffs are not rendered by default.
Oops, something went wrong.
146 changes: 99 additions & 47 deletions
146
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
| import { ProviderDriverKind, type ProviderOptionDescriptor } from "@t3tools/contracts"; | ||
|
|
||
| import { buildTraitsTriggerDisplay } from "./modelTraits.ts"; | ||
|
|
||
| describe("composer thinking summary", () => { | ||
| it.each([ | ||
| { thinking: true, toggleFirst: false, effort: "effort", label: "Extra High · 1M" }, | ||
| { thinking: true, toggleFirst: true, effort: "effort", label: "Extra High · 1M" }, | ||
| { thinking: false, toggleFirst: false, effort: "effort", label: "Off · 1M" }, | ||
| { thinking: false, toggleFirst: true, effort: "effort", label: "Off · 1M" }, | ||
| { thinking: true, toggleFirst: true, effort: "thought_level", label: "Extra High · 1M" }, | ||
| { thinking: false, toggleFirst: false, effort: "thought_level", label: "Off · 1M" }, | ||
| { thinking: true, toggleFirst: true, effort: null, label: "Thinking · 1M" }, | ||
| { thinking: false, toggleFirst: true, effort: null, label: "Off · 1M" }, | ||
| ])("shows $label with thinking=$thinking and toggleFirst=$toggleFirst", (testCase) => { | ||
| const thinking: ProviderOptionDescriptor = { | ||
| id: "thinking", | ||
| label: "Thinking", | ||
| type: "boolean", | ||
| currentValue: testCase.thinking, | ||
| }; | ||
| const effort: ProviderOptionDescriptor = { | ||
| id: testCase.effort ?? "effort", | ||
| label: "Reasoning", | ||
| type: "select", | ||
| ...(testCase.effort === "thought_level" ? { role: "reasoning" as const } : {}), | ||
| currentValue: "xhigh", | ||
| options: [{ id: "xhigh", label: "Extra High" }], | ||
| }; | ||
| const descriptors: Array<ProviderOptionDescriptor> = [ | ||
| ...(testCase.effort | ||
| ? testCase.toggleFirst | ||
| ? [thinking, effort] | ||
| : [effort, thinking] | ||
| : [thinking]), | ||
| { | ||
| id: "contextWindow", | ||
| label: "Context Window", | ||
| type: "select", | ||
| currentValue: "1m", | ||
| options: [{ id: "1m", label: "1M" }], | ||
| }, | ||
| ]; | ||
| expect( | ||
| buildTraitsTriggerDisplay({ | ||
| provider: ProviderDriverKind.make("claudeAgent"), | ||
| descriptors, | ||
| primarySelectDescriptorId: testCase.effort ?? "contextWindow", | ||
| ultrathinkPromptControlled: false, | ||
| }), | ||
| ).toMatchObject({ | ||
| label: testCase.label, | ||
| thinkingOff: !testCase.thinking, | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.