Skip to content

i18n(ja): keep gauge/count/histogram metric type values in English - #23841

Draft
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-metric-type-english-terms
Draft

i18n(ja): keep gauge/count/histogram metric type values in English#23841
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-metric-type-english-terms

Conversation

@yahonda

@yahonda yahonda commented Sep 11, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

In the Japanese translations of the Datadog, New Relic, and Prometheus/Grafana
integration docs, the "metric type" column had translated the literal metric
type values into katakana:

  • gauge -> ゲージ
  • count -> カウント
  • histogram -> ヒストグラム

These are literal enum values from each monitoring system's own API/metadata
(matching the English source verbatim), not prose to translate, so this PR
reverts them to English. This also makes monitor-datadog-integration.md
consistent with its sibling monitor-datadog-integration-for-tidb-x.md,
which already kept these values in English.

Files changed:

  • tidb-cloud/monitor-datadog-integration.md
  • tidb-cloud/monitor-new-relic-integration.md
  • tidb-cloud/monitor-prometheus-and-grafana-integration.md
  • tidb-cloud/prometheus-grafana-integration.md

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

The metric type column in the Datadog, New Relic, and Prometheus/Grafana
integration docs had been translated to katakana (gauge -> ゲージ,
count -> カウント, histogram -> ヒストグラム). These are literal metric
type values from the monitoring systems' own APIs, matching the English
source and the untranslated sibling doc (monitor-datadog-integration-for-tidb-x.md),
so they should stay in English.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2026
The previous commit's blanket replacement incorrectly turned the prose
description "ステートメントの期間ヒストグラム" (a natural Japanese
statistics term) into "ステートメントの期間histogram". Only the Type
column's literal metric-type value should stay in English; restore the
katakana term in the prose description.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant