i18n(ja): restore literal English panel-name headings in Performance Overview dashboard docs by yahonda · Pull Request #23820 · pingcap/docs

yahonda · 2026-09-10T06:51:45Z

What is changed, added or deleted? (Required)

Connection Idle Duration and 8 sibling section headings in grafana-performance-overview-dashboard.md and dashboard/dashboard-monitoring.md are real Grafana panel titles (verified against the performance_overview.json dashboard definition in pingcap/monitoring), but were translated into Japanese instead of being kept literal, unlike their sibling bullet entries which were already literal English in dashboard/dashboard-monitoring.md.

This PR restores the literal English panel names in the affected headings:

Database Time by SQL Type
Database Time by SQL Phase
CPS By Type
Duration
Connection Idle Duration
Connection Count
Parse Duration, Compile Duration, and Execute Duration
Avg TiDB KV Request Duration
Avg TiKV GRPC Duration
PD TSO Wait/RPC Duration
Storage Async Write Duration, Store Duration, and Apply Duration
Append Log Duration, Commit Log Duration, and Apply Log Duration

It also literalizes the Connection Idle Duration panel-name reference in the intro sentence right below that heading in both files, which incidentally removes a tautological "duration ... duration" repetition in the Japanese sentence.

Which TiDB version(s) do your changes apply to? (Required)

i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

AI agent involvement

The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Summary by CodeRabbit

Documentation
- Updated monitoring dashboard documentation to use the English metric name “Connection Idle Duration.”
- Renamed the SQL execution-plan timing metric from “Execution Duration” to “Execute Duration” in both dashboard documentation sets.

ti-chi-bot · 2026-09-10T06:51:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-09-10T06:52:38Z

Warning

Review limit reached

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0c94b3df-97e5-402e-b897-f2b4ca2433eb

📥 Commits

Reviewing files that changed from the base of the PR and between 645c2ff and 5431b99.

📒 Files selected for processing (2)

dashboard/dashboard-monitoring.md
grafana-performance-overview-dashboard.md

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 244d5ba9-3354-415c-a704-5d295ed1c2a6

📥 Commits

Reviewing files that changed from the base of the PR and between 49380b0 and 5431b99.

📒 Files selected for processing (2)

dashboard/dashboard-monitoring.md
grafana-performance-overview-dashboard.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Walkthrough

Both dashboard documents update the Connection Idle Duration description and rename the Execution Duration label to Execute Duration.

Changes

Dashboard metric terminology

Layer / File(s)	Summary
Update dashboard metric labels `dashboard/dashboard-monitoring.md`, `grafana-performance-overview-dashboard.md`	The Connection Idle Duration descriptions use the English metric name. The Execution Duration label is renamed to Execute Duration.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5431b

The documentation updates consistently restore the intended dashboard metric names with no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Japanese localization change and the restoration of literal English panel-name headings in the Performance Overview dashboard documentation.
Description check	✅ Passed	The description explains the changes, lists the affected panel names, identifies the TiDB version scope, and records AI agent involvement. Optional reference links are left empty, but the required inf…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…Overview dashboard docs Connection Idle Duration and 8 sibling headings are real Grafana panel titles (verified against pingcap/monitoring dashboard JSON) but were translated into Japanese, unlike their sibling bullet entries which were already kept literal. Also literalize the Connection Idle Duration panel-name reference in the intro sentence, which removes a tautological "duration...duration" repetition in Japanese as a side effect.

…ype-list wording Ten bullet labels under Duration/Parse-Compile-Execute Duration/ Storage-Async-Write-Store-Apply Duration/Append-Commit-Apply Log Duration reuse their section heading's name as the bullet's own subject, matching a real Grafana panel/series name, but were still translated into Japanese even after the heading itself was fixed. Also unify a stray Execution Duration to Execute Duration to match the real panel name, and fix a machine-translation word-order defect in three type-list bullets (QPS, KV/TSO Request OPS, avg by type) where SELECT/INSERT/UPDATE and Get/Prewrite/Commit tokens were scrambled out of their sentence context.

yahonda · 2026-09-11T00:39:34Z

@coderabbitai full review

coderabbitai · 2026-09-11T00:39:38Z

⚠️ Action not completed

Review rate limited.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 25 minutes.

ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 10, 2026

ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2026

qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 10, 2026

yahonda added 2 commits September 11, 2026 09:05

yahonda force-pushed the fix-performance-overview-panel-names branch from 49380b0 to 5431b99 Compare September 11, 2026 00:08

ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2026

Navigation Menu

Uh oh!

i18n(ja): restore literal English panel-name headings in Performance Overview dashboard docs - #23820

i18n(ja): restore literal English panel-name headings in Performance Overview dashboard docs#23820
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-performance-overview-panel-names

yahonda commented Sep 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

ti-chi-bot Bot commented Sep 10, 2026

Uh oh!

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

Review limit reached

Reviews paused

Walkthrough

Changes

Uh oh!

yahonda commented Sep 11, 2026

Uh oh!

coderabbitai Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yahonda commented Sep 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

AI agent involvement

Do your changes match any of the following descriptions?

Summary by CodeRabbit

Uh oh!

ti-chi-bot Bot commented Sep 10, 2026

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Reviews paused

Walkthrough

Changes

Uh oh!

yahonda commented Sep 11, 2026

Uh oh!

coderabbitai Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yahonda commented Sep 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

coderabbitai Bot commented Sep 11, 2026 •

edited

Loading