Skip to content

phpbb-test-boards: require the full supported database matrix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonelifer merged 2 commits into from
Nov 9, 2026
Merged

phpbb-test-boards: require the full supported database matrix #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c375e1
phpbb-test-boards: require the full supported database matrix
bonelifer Nov 6, 2026
bcb1f8c
Merge main into require-full-phpbb-database-matrix
bonelifer Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion phpbb-test-boards/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ Test every code change on a running board before opening its pull request, not a

Use committed `smoke_test.py`, `feature_checks.py`, and `run-unit-tests.sh` where relevant. Inspect their current interfaces and dependency installation options. The unit-test runner manages its own fresh test copies and compatible phpBB/PHPUnit checkout; that is distinct from manually copying an interactive board. Preserve a required `tests/functional/` directory when the framework enumerates it.

Provision supported database cases rather than calling a SQLite pass universal. The supported matrix is MySQL/MariaDB, PostgreSQL, SQLite and MSSQL. phpBB is dropping Oracle, so extensions do not support, test or write Oracle-specific code for it; do not list it as an untested gap either. Run guest/admin routes, real ACP/MCP/UCP actions, cron, permissions, and disable/purge/enable lifecycle cases that the change affects. Add reusable feature checks to the committed harness when appropriate. Do not let a green lint/EPV run stand in for runtime evidence.
Provision supported database cases rather than calling a SQLite pass universal. Before opening a pull request with a phpBB extension code change, run the affected behavior on every supported phpBB branch and database combination: SQLite, MySQL, MariaDB, PostgreSQL and MSSQL, in disposable containers bound to 127.0.0.1 and removed afterwards. For an extension supporting phpBB 3.3 and 4.0, that is ten board cases; a SQLite run is only an initial check. phpBB is dropping Oracle, so extensions do not support, test or write Oracle-specific code for it; do not list it as an untested gap either.

Use `phpbb-test-board/db-matrix.sh` with an extension-specific feature check for the actual behavior; a skipped feature check does not satisfy the matrix. The SQL Server image only starts with `ACCEPT_EULA=Y`, which accepts Microsoft's SQL Server Developer licence. That acceptance is the user's decision: check the agent's persistent memory for a recorded approval covering local disposable test containers. If there is one, use it without asking again; if not, ask once, and record the answer in memory when the user approves. Never set it without either. The same applies to pulling a database image that is not cached yet.

Run guest/admin routes, real ACP/MCP/UCP actions, cron, permissions, and disable/purge/enable lifecycle cases that the change affects. Add reusable feature checks to the committed harness when appropriate. Do not let a green lint/EPV run stand in for runtime evidence.

Purge through seed-forum or the correct board owner when CLI cannot remove web-owned cache. For `php -S`, disable opcache in the disposable test runtime. Empty pages may hide PHP fatals: inspect response bodies and logs before diagnosing flakiness. Wait for phpBB's form timing/CSRF requirements before submitting browser forms.

Expand Down
Loading