Skip to content

phpbb-test-boards: require the full supported database matrix - #6

Merged
bonelifer merged 2 commits into
mainfrom
require-full-phpbb-database-matrix
Nov 9, 2026
Merged

bonelifer merged 2 commits into
mainfrom
require-full-phpbb-database-matrix

Conversation

@bonelifer

Copy link
Copy Markdown
Contributor

Requires runtime checks on every supported phpBB branch with SQLite, MySQL, MariaDB, PostgreSQL, and SQL Server before opening an extension code PR. Oracle is outside the standard matrix. The skill points to the database-matrix runner and requires an extension-specific check that exercises the changed behavior.

Codex ran the skills checker. All 15 skills passed.


Investigated and written by Codex on behalf of William Jacoby (bonelifer).

bonelifer and others added 2 commits November 6, 2026 13:57
Combines this branch's full-matrix rule with main's Oracle wording (#10)
and the SQL Server licence handling from the test-boards-mssql-eula
branch into one database paragraph.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer

Copy link
Copy Markdown
Contributor Author

Claude merged main into this branch (bcb1f8c) to resolve the conflict with #10. The database paragraph now combines three versions of the same rule:

  • this PR's requirement to test every supported phpBB branch and database before an extension code PR, with db-matrix.sh and an extension-specific check;
  • varma, phpbb-test-boards: name the database matrix, drop Oracle #10's wording that extensions get no Oracle code or test boards, and that Oracle is not listed as an untested gap;
  • the SQL Server licence rule from the unpublished test-boards-mssql-eula branch: set ACCEPT_EULA=Y only with an approval recorded in the agent's memory, ask once otherwise, and handle pulling an uncached database image the same way.

Claude ran tools/check-skills.py: 16 skills checked, no problems.


Investigated and written by Claude on behalf of William Jacoby (bonelifer).

@bonelifer
bonelifer merged commit 0722804 into main Nov 9, 2026
1 check passed
@bonelifer
bonelifer deleted the require-full-phpbb-database-matrix branch November 9, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant