Repository navigation
Conversation
Work in progress, not finished or tested: ACP settings module with a migration keeping existing settings, bundled message trimmer instead of nickvergessen/phpbb-tool-trimmessage, version 1.4.0-dev for phpBB 3.3.19+, updated tests and a phpBB 3.3 compatibility workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Package, namespace, services, routes and language/template paths move to phpbbmodders/newspage; the PHP events keep their old names. ext.php refuses to enable while nickvergessen/newspage is on and moves its migrations, modules and record when enabled. - phpBB 3.3.19 to 4.0, PHP 7.4+: avatars through 4.0's avatar helper, no Jabber column, Font Awesome 6 icon classes, 4.0's index.php routes in Who is online, the log service instead of add_log(). - Settings service reduced to what the ACP uses; tests run under phpBB's test bootstrap, with new settings, trimmer and 4.0 Who is online tests. - CI: test framework on 3.3.x and master, strict EPV, PHP 7.4/8.4 lint; Travis, Phing, composer.phar/lock and the WIP workflow removed. - Org file headers and composer.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- README rewritten for the org layout: features, screenshots, requirements, installation and upgrading from nickvergessen/newspage. - Screenshots of the news page, a news item, the ACP settings and the phone layout, with a gallery page; docs/images is left out of release ZIPs, as are tests and CI files. - The template events keep their nickvergessen_newspage_* names, as the PHP events do, so styles and listeners written for them keep working. - docs/TODO.md lists what is left; the repository's own SECURITY.md and issue templates are removed so the organization's apply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
phpBB's CI configuration names a functional test folder, and its PostgreSQL, MySQL, MSSQL and Windows jobs stop when it is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the phpBB 3.3 port of NV Newspage, moves it to the
phpbbmodders/newspagename and adds phpBB 4.0 support. It builds on the 10/07–10/08/2026 work-in-progress commit already on this branch, which moved the settings to the ACP and replaced the old message-trimming library.Name
ext/phpbbmodders/newspage), services, routes and language/template paths move tophpbbmodders/newspage.nickvergessen.newspage.newspage,nickvergessen.newspage.single_news) and the template events (nickvergessen_newspage_*) keep their names, so listeners and styles written for them keep working.ext.phprefuses to enable whilenickvergessen/newspageis enabled. When enabled, it moves the old install's migration history, ACP modules and extension record to the new name, using the same code as contactadmin and the wiki.phpBB 3.3.19 to 4.0, PHP 7.4 or later
composer.jsonallows>=3.3.19,<4.1.0@dev.ext.phpchecks phpBB 3.3.19, PHP 7.4 and the DOM extension, which the message trimmer needs.phpbb_get_user_avatar(). The news page gets 4.0's avatar helper as an optional service and builds the same<img>markup, so one template works on both.fas/far), so they draw on 4.0. The post icon before the author replaces the bare "Post" text the old image placeholder gave. The "Top" text link after each news item is now the back-to-top arrow, as in phpBB's viewtopic.index.php/news/..., notapp.php/news/.... Both are recognised now.add_log()no longer exists in 4.0.public staticinstead ofstatic public, which 4.0's code sniffer rejects.Settings and tests
dispatch()takes its arguments in a different order on 4.0.CI and repository
tests.yml: the test framework on phpBB 3.3.x (PHP 7.4–8.2) and master (PHP 8.2–8.4), plus the strict EPV workflow for both.lint.yml: PHP 7.4 and 8.4 syntax andcomposer validate.build.xml),composer.phar,composer.lock, the WIP's own workflows and its board scripts, the repository's ownSECURITY.mdand issue templates (the organization's apply), and the tests' own bootstrap..github/epv-allowed.txtkeepsext.php'sunserializeand threehtmlspecialcharscalls that must not escape stored text twice.composer.jsonfollow the organization's format. There's noversion-checkblock yet: no phpBB.com listing could be confirmed, whichdocs/TODO.mdnotes.docs/images/screenshots/, with a gallery page that also shows the news page with poster information and buttons on, shortened, and without filters;docs/images/, tests and CI files are left out of release ZIPs.Testing
Claude ran:
The unit tests on phpBB 3.3.x and master: 158 tests pass on both.
phpBB 3.3's and 4.0's code sniffers: no findings. EPV (for 3.3 and 4.0) through the strict workflow's filter: no findings outside the allowlist.
seed-forum boards on phpBB 3.3.19 and 4.0.0-a3-dev, each:
The upgrade on both boards: the original
nickvergessen/newspage1.1.1 frommainenabled, settings changed, then:The original 1.1.1 news page itself returns HTTP 500 on phpBB 3.3, as expected for phpBB 3.1 code.
Not covered: the screenshot tool's board is phpBB 3.3 only, so the screenshots are from 3.3. The German translation has no ACP or install strings yet; they fall back to English (in
docs/TODO.md).The screenshots come from phpbbmodders/phpbb-release-tools#32, which adds Newspage to
screenshots.py.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code