Repository navigation
run-unit-tests.sh: require a tests/functional folder - #33
Merged
Merged
Conversation
phpbb-extensions/test-framework runs PHPUnit with phpBB's own configuration, which lists the extension's tests/functional folder; its PostgreSQL, MySQL, MSSQL and Windows jobs stop when the folder is missing. Refuse to run without it, with the command that adds it, so this shows up before CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
run-unit-tests.shrefuse to run an extension that has notests/functionalfolder, and say how to add one (mkdir -p tests/functional && touch tests/functional/.gitkeep).phpbb-extensions/test-framework runs PHPUnit with phpBB's own
.github/phpunit-*.xml, which lists the extension'stests/functionalfolder. Without it, the PostgreSQL, MySQL, MSSQL and Windows jobs stop withTest directory ".../tests/functional" not found, and the rest of the matrix gets cancelled, even with functional tests turned off. The SQLite and no-database jobs pass, so it's easy to miss until CI runs. phpbbmodders/phpbb-ext-newspage#2 hit this; an empty folder fixed it.run-unit-tests.shis meant to run tests the way CI does, so it now stops at the same point, before cloning anything. The help text,phpbb-test-board/README.mdand the option tests (2 new checks) cover it.Of the org's extensions with a
phpunit.xml.dist, only phpbbmodders/documentation still has notests/functionalfolder. Its database and Windows jobs are switched off, so its CI passes, but this script will refuse it until the folder is added.Claude ran
tests/test-phpbb-test-board.sh(all pass) and ShellCheck, and ran the script on phpbb-ext-newspage, which now has the folder: 158 tests pass.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code