Skip to content

ext/zip: Exclude broken libzip 1.12(.0) - #24358

Open
LamentXU123 wants to merge 1 commit into
php:PHP-8.3from
LamentXU123:exclude-1.12-libzip
Open

LamentXU123 wants to merge 1 commit into
php:PHP-8.3from
LamentXU123:exclude-1.12-libzip

Conversation

@LamentXU123

Copy link
Copy Markdown
Member

libzip 1.12 introduced a regression that prevents adding or replacing files in TorrentZip archives, causing oo_torrentzip.phpt to fail. This was fixed in libzip 1.12.1.

Exclude both 1.12 and 1.12.0 at configure time, as pkg-config treats them as distinct versions (wtf bro).

See nih-at/libzip#617.

@iliaal

iliaal commented Oct 15, 2026

Copy link
Copy Markdown
Member

LGTM, Do we need this for 8.3 and 8.2 as well?

@LamentXU123

LamentXU123 commented Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

I dont think we have that feature in 8.2. So if we are going to backport to security-only branches this should target 8.3.
I will first merge this because it's burning CI. If @php/release-managers-83 think this should be backported feel free to tell me I will create a commit to backport.

Oh I just realised this will not fix CI instantly, we need to wait for homebrew's image to update itself. Okay than we don't need to rush anyways. Let's wait for 8.3 RM's opinion.

@LamentXU123
LamentXU123 requested a review from a team October 15, 2026 18:29
@LamentXU123
LamentXU123 marked this pull request as draft October 15, 2026 18:32
@LamentXU123
LamentXU123 changed the base branch from PHP-8.4 to PHP-8.3 October 15, 2026 18:33
@LamentXU123
LamentXU123 marked this pull request as ready for review October 15, 2026 18:33
@andypost

Copy link
Copy Markdown
Contributor

the fix is nih-at/libzip@e3f6db9 but better to beware this version sadly no way for 8.2/8.3

@LamentXU123 LamentXU123 changed the title ext/zip: Exclude broken libzip 1.12 ext/zip: Exclude broken libzip 1.12(.0) Oct 16, 2026
@Sjord

Sjord commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Looks good to me. Does the Windows build config also need such a check?

@LamentXU123

Copy link
Copy Markdown
Member Author

Looks good to me. Does the Windows build config also need such a check?

Well, seems like the former excluded version ain't added in Windows build condig either! Thank you for reminding.

Yes. And I will also file a PR to add 1.3.1 and 1.7.0 as excluded version in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants