Repository navigation
ext/standard: Convert levenshtein to fast ZPP - #24369
Conversation
|
Fast ZPP inlines the parsing into every function, so it's only worth the extra code size on hot paths. The DNS functions are dominated by the network round trip, and the base php_user_filter::filter() just returns PSFS_ERR_FATAL, so these conversions grow the binary with no gain. levenshtein() is the only arguable one here, and even there the O(n*m) loop dwarfs argument parsing. I'd drop this. |
|
I see, haven't thought in this point of view. |
levenshtein to fast ZPP
8d264f3 to
464e877
Compare
iliaal
left a comment
There was a problem hiding this comment.
Yeah, if benchmark shows a big uplift, 38% fits that imho just focusing on that gets my +1
|
Looks good to me.
Is this due to #24358? |
Yes. There is nothing to do about it unfortunately. We just need to wait for the mirror to update itself. |
|
Thanks! |
No description provided.