fix: treat --apply/--contain as flags, not user text - #254
Merged
Conversation
Payload tokens equal to --apply or --contain were treated as already-present CLI flags, so apply could dry-run and --contain could be dropped. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
AGENTS.md said batch plans are JSON and CI is self-hosted. The walkthrough said Configure MCP writes every editor automatically. ROADMAP still listed shipped Marketplace, CI, and managed install as future work. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat
--applyand--containas CLI flags, not as user payload tokens, and correct a few stale contributor docs.Why
withApplyFlagandwithContainFlagusedargs.includes(...). If a Quick Action value was exactly--applyor--contain(for example replace old text), the helper treated that token as the flag.--apply, so a confirmed apply became a dry run.--containcould be omitted, so the CLI was no longer limited to the workspace.The change
withApplyFlagonly treats a trailing--applyas already present (the helper always appends).withContainFlagonly treats a leading--containas already present (the helper always prefixes).mcpServerskey; ROADMAP lists shipped Marketplace/CI/managed install as shipped.Verification
npx tsc -p ./tsconfig.test.json && node --test ./out-test/test/unit/quickActions.test.jsfailed on the new payload-token cases and the trailing--containexpectation.npm run checkpassed (431 unit tests, coverage, package).Checklist
git commit -snpm run checkand it passes