refactor: serialize --apply and --contain from flags - #255
Merged
Conversation
Quick Action builders kept operands in a string array, then later helpers scanned that array for flag names. User text equal to --apply or --contain looked like a flag. Put apply/contain on PatchloomInvocation and write argv only in serializePatchloomArgs. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build Patchloom argv from structured flags instead of scanning a flat
string[]for--applyand--contain.Why
PR #254 stopped
Array.includesfrom treating user text as a flag. That was still argv surgery: helpers looked at token slots in the same array that holds replace/search text.The extension is not a CLI parser. It should not search operands for option names.
The change
PatchloomInvocationcarriesargs,apply, andcontain.serializePatchloomArgsprefixes--containand appends--applyfrom those booleans only.create,undo,patch apply,patch merge) setapply: trueand no longer put--applyinargs.executePatchloomserializes atexecFile.This does not add commander/yargs. It also does not change how clap sees a positional that looks like a flag (for example replace old text
--apply). That would need a named operand on the CLI.Verification
npm run checkpassed (429 unit tests, 7 skipped, coverage, package).Checklist
git commit -snpm run checkand it passes