Add active border drawing to RulerWindow and RulerContentView#261
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
[codex reviewer] Reviewed this against No blocking findings. The active-border state is centralized in Verification: |
* Introduced `drawsActiveBorder` property to `RulerWindow` and `RulerContentView` to manage the visibility of an active border. * Updated `RulerWindowBorderView` to draw an active border based on the new property. * Implemented logic in `RulerManager` to ensure only the active ruler displays the active border. * Added unit test to verify active border behavior for active and inactive rulers.
e861ccd to
5acd0f4
Compare
9e34ae9 to
3363dc3
Compare

Summary
Tests
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTestsxcodebuild -derivedDataPath /private/tmp/freeruler-active-border-derived-data -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTests/RulerCoreTests/testRulerManagerDrawsActiveBorderOnlyOnActiveRulergit diff --checkFixes #260