Refactor: Remove LegacyRulerWindow and related constructs#259
Conversation
…lerController, updating related window handling and layout structures. Rename grouped ruler references to align with new architecture, enhancing clarity and maintainability. Remove LegacyRulerWindow and adjust associated tests for consistency.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pascalpp
changed the title
…nces window * Implemented writing of active settings state in UITestSupport for better UI testing. * Added accessibility identifier to the preferences window for improved accessibility. * Updated UITests to reflect changes in ruler window references and ensure consistent behavior across tests.
|
[codex reviewer] Reviewed this against No blocking findings. I focused on the legacy-window removal path: saved-state restore/migration, active ruler settings, per-ruler redraw behavior, close/toggle/reset hotkeys, and the UI-test identifier updates. The direct diff looks internally consistent; the remaining legacy window/controller surface is gone, and Verification: |
1 participant
Summary
LegacyRulerWindowand the old standalone ruler window/controller path.RulerWindow/RulerController, with each ruler capable of showing its horizontal wing, vertical wing, or both.Gnow represents grouped dragging only, and update unit/UI coverage for the unified ruler-window model.Verification
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTestsxcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerUITestsCloses #251