Skip to content

medik8s/system-tests: use Go 1.27 builder image as build_root - #85308

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jmontleon:medik8s-system-tests-build-root
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jmontleon:medik8s-system-tests-build-root

Conversation

@jmontleon

@jmontleon jmontleon commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

The system-tests suites now require Go >= 1.27.1 to compile the operators under test, but the newest official CI builder is golang-1.26, so jobs fail with "go.mod requires go >= 1.27.1 (running go 1.26.7)".

Point the system-tests build_root at medik8s/builder:go1.27 (imported separately) and regenerate jobs. Revert once an official golang-1.27 builder exists in the ocp/openshift namespaces.

Depends on the medik8s/builder:go1.27 imagestream being applied first.

Summary by CodeRabbit

The Medik8s system-test CI jobs now use the medik8s/builder:go1.27 image as their build_root for the 4.21, 4.22, and 5.0 configurations. This provides the Go 1.27.1 toolchain required by the test suites.

Apply the medik8s/builder:go1.27 ImageStream before using these jobs. Revert this workaround when an official Go 1.27 builder becomes available.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b6987481-8d0b-4332-ac82-c62f5a8ad972

📥 Commits

Reviewing files that changed from the base of the PR and between 2ec389a and 0786c78.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/medik8s/system-tests/medik8s-system-tests-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/medik8s/system-tests/medik8s-system-tests-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.21-disconnected.yaml
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-upgrade.yaml
  • ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__5.0.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The five Medik8s system-test configurations now use the medik8s builder ImageStream tagged go1.27 for build_root instead of building from the repository.

Changes

Medik8s build root configuration

Layer / File(s) Summary
Use the go1.27 builder ImageStream
ci-operator/config/medik8s/system-tests/*
The five configurations replace from_repository: true with the medik8s builder:go1.27 ImageStream reference.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 0786c

The CI configurations use the intended Go 1.27 builder image, with no identified merge-blocking impact.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: configuring medik8s system tests to use the Go 1.27 builder image as build_root.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request does not introduce or change Ginkgo test titles. The authoritative diff changes five YAML build_root entries from from_repository: true to the static medik8s/builder:go1.27 imag…
Test Structure And Quality ✅ Passed PASS: The reviewed range changes only seven YAML files. The five system-test config changes replace from_repository: true with medik8s/builder:go1.27; the remaining changes are generated Prow job …
Microshift Test Compatibility ✅ Passed The pull request does not add or modify Ginkgo e2e tests. The authoritative diff contains only five build-root configuration changes and generated Prow job updates; no Go, test, or Ginkgo declaration …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only seven YAML CI configuration/job files. The diff replaces build_root with medik8s/builder:go1.27 and updates generated cloning settings. It adds no Ginkgo tests …
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only seven CI YAML files. The config changes replace from_repository: true with the medik8s/builder:go1.27 image stream tag. The generated job changes replace sparse check…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only CI YAML. It replaces repository build roots with medik8s/builder:go1.27 and updates generated job checkout settings. No Go or other source-language files changed,…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only seven YAML CI configuration files. The authoritative diff contains no Go files, Ginkgo test declarations, IPv4 addresses, or external connectivity code. The new `me…
No-Weak-Crypto ✅ Passed PASS — The pull request changes only CI YAML. The five config files replace from_repository: true with medik8s/builder:go1.27; generated job files replace sparse checkout entries with `skip_clonin…
Container-Privileges ✅ Passed The PR does not introduce any listed privilege condition. The config diff only replaces from_repository: true with image_stream_tag for medik8s/builder:go1.27. Added generated-job lines only set…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request introduces no logging statements, log arguments, or sensitive values. The configuration changes only replace repository-based build roots with medik8s/builder:go1.27. Regenera…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@jmontleon

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-mdr-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jmontleon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The system-tests suites now require Go >= 1.27.1 to compile the operators
under test, but the newest official CI builder is golang-1.26, so jobs fail
with "go.mod requires go >= 1.27.1 (running go 1.26.7)".

Point the system-tests build_root at medik8s/builder:go1.27 (imported
separately) and regenerate jobs. Revert once an official golang-1.27 builder
exists in the ocp/openshift namespaces.

Depends on the medik8s/builder:go1.27 imagestream being applied first.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jmontleon
jmontleon force-pushed the medik8s-system-tests-build-root branch from 0786c78 to b9b49e4 Compare September 16, 2026 20:50
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jmontleon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-system-tests-main-4.22-upgrade-e2e-far-upgrade-presubmit-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-far-aws-disconnected medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-nhc-aws-disconnected medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-sbr-aws-disconnected-nfs medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-snr-aws-disconnected medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-mdr-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-aws medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-aws-efs medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-hypershift-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-hypershift-persistent-aws-odf medik8s/system-tests presubmit Ci-operator config changed
pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-snr-aws medik8s/system-tests presubmit Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.21-disconnected-e2e-sbr-weekly-aws-disconnected-nfs N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-far-weekly-aws-disconnected N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-nhc-weekly-aws-disconnected N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-5.0-tls13-adherence-all N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-snr-weekly-aws-disconnected N/A periodic Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-odf N/A periodic Ci-operator config changed

A total of 31 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jmontleon

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-nhc-interop-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-mdr-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-aws pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-nmo-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jmontleon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jmontleon

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-konflux-e2e-far-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jmontleon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@weshayutin weshayutin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmontleon, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit cc83957 into openshift:main Sep 16, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants