Skip to content

remove all medik8s prow jobs except for system-tests - #85307

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
weshayutin:nuke-medik8s-prow
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
weshayutin:nuke-medik8s-prow

Conversation

@weshayutin

@weshayutin weshayutin commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

replacing any developer ci w/ github actions due to resource constraints

Summary by CodeRabbit

  • Removes Prow CI configuration for seven Medik8s components, including release jobs, image builds, unit tests, and AWS end-to-end tests.
  • Removes the related generated OWNERS files and release-branch guidance.
  • Retains the Medik8s system-tests configurations.
  • Moves developer CI to GitHub Actions to reduce Prow resource usage.
  • Test execution is not reported.

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request deletes Medik8s ownership metadata, release guidance, and CI-Operator configurations for six components. The removed configurations covered image and bundle builds, release targets, resources, unit tests, AWS end-to-end workflows, and optional validation workflows.

Changes

Medik8s CI configuration removal

Layer / File(s) Summary
Fence agents remediation CI removal
ci-operator/config/medik8s/fence-agents-remediation/*
Removes ownership metadata, README guidance, and CI configurations for main and release variants.
Machine deletion remediation CI removal
ci-operator/config/medik8s/machine-deletion-remediation/*
Removes ownership metadata, README guidance, and CI configurations for main and release variants.
Node healthcheck operator CI removal
ci-operator/config/medik8s/node-healthcheck-operator/*
Removes ownership metadata, README guidance, and CI configurations for main and release variants.
Node maintenance operator CI removal
ci-operator/config/medik8s/node-maintenance-operator/*
Removes ownership metadata, README guidance, and CI configurations for main and release variants.
Node remediation console CI removal
ci-operator/config/medik8s/node-remediation-console/*
Removes ownership metadata, README guidance, and main and release CI configurations, including lint-test settings.
Self-node remediation and storage-based remediation CI removal
ci-operator/config/medik8s/self-node-remediation/*, ci-operator/config/medik8s/storage-based-remediation/*
Removes ownership metadata, README guidance, and CI configurations for main and release variants. Storage-based remediation configurations also included ODF setup, artifact collection, and AWS end-to-end workflows.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 57b7c

No concrete merge-blocking risk is established by the finalized evidence.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: it removes all Medik8s Prow job configurations except system-tests, which matches the listed deletions and the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The review-scoped diff contains 142 deleted files, with 0 added lines and 0 modified files. The changes remove Medik8s CI configuration and metadata only. No added Ginkgo test titles or dynamic …
Test Structure And Quality ✅ Passed PASS. The review-scoped diff contains 142 deletions only, all under ci-operator/config/medik8s/; it changes no Go, Ginkgo, or test source. The patch adds zero lines and deletes CI configuration, REA…
Microshift Test Compatibility ✅ Passed The MicroShift Test Compatibility check is not triggered. The review-scoped diff contains 142 deleted files and 12,745 deletions, all under ci-operator/config/medik8s/; it contains no added files, n…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The reviewed range contains 142 deleted files and no additions or modifications. All changes are under ci-operator/config/medik8s/, and the diff has 0 insertions. Therefore, the pull request a…
Topology-Aware Scheduling Compatibility ✅ Passed The check is not applicable. The authoritative PR diff contains 142 deleted files, all under ci-operator/config/medik8s/, with no added or modified deployment manifests, operator code, or controller…
Ote Binary Stdout Contract ✅ Passed PASS: The reviewed range contains 142 deletions only. All changed files are Medik8s CI YAML, OWNERS, or README files under ci-operator/config/medik8s. No Go or test source changed, and no added stdout…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The reviewed range contains only 142 deleted files. It has 0 added lines and no added Ginkgo test markers such as It(), Describe(), Context(), or When(). Therefore, this pull request introduces …
No-Weak-Crypto ✅ Passed PASS. The reviewed range contains 142 deleted files and no added or modified content. The patch removes Medik8s CI configurations only; it does not introduce MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB,…
Container-Privileges ✅ Passed PASS: The reviewed range contains 142 deletions only. It adds 0 lines and has no modified or added files. Therefore, it does not introduce privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN,…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The authoritative diff contains 142 deletions only, with 0 added lines and no changed paths outside the Medik8s Prow configuration tree. No logging, output statements, or sensitive-data handling…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from abrugaro and beekhof September 16, 2026 14:10
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@weshayutin: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mshitrit

Copy link
Copy Markdown
Contributor

/lgtm

This is a big change, among other things removing running of current e2e test via prow.
As discussed, the rational is having those tests running in a more consistent way via github actions.

Ideally the new safety net (i.e tests) should be in place before merging this PR, however after discussing it with @weshayutin we'll do the removal first as it blocks critical tasks.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit

Copy link
Copy Markdown
Contributor

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mshitrit: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mshitrit: no rehearsable tests are affected by this change

@openshift-merge-bot
openshift-merge-bot Bot merged commit fb670f5 into openshift:main Sep 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants