Skip to content

Using an image with certificates for ldap connection - #85306

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:certs-for-sync-rover-groups
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:certs-for-sync-rover-groups

Conversation

@hector-vido

@hector-vido hector-vido commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Since unauthenticated calls for ldap.corp.redhat.com are not allowed, we need to use an image with valid CA certs.

Summary by CodeRabbit

The sync-rover-groups image in the OpenShift CI Tools configuration now uses the OpenShift RHEL 9 Go 1.26 release image. This provides CA certificates required for the LDAP connection to ldap.corp.redhat.com.

The image build no longer installs tar, git, or diffutils.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a69eb357-8dcf-45fb-985e-430981cfe7e6

📥 Commits

Reviewing files that changed from the base of the PR and between f21caf5 and e178f6f.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The sync-rover-groups image now uses the OpenShift RHEL 9 Go 1.26 release image. The image configuration no longer installs tar, git, or diffutils.

Changes

sync-rover-groups image

Layer / File(s) Summary
Update image base
ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
The image changes from UBI Minimal to the OpenShift RHEL 9 Go 1.26 release image and removes runtime installation of tar, git, and diffutils.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: using an image with valid certificates for the LDAP connection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only the sync-rover-groups image base in ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. The patch adds no Ginkgo tests or test titles, so it introduce…
Test Structure And Quality ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. The patch updates the sync-rover-groups image base and removes package installation commands…
Microshift Test Compatibility ✅ Passed The pull request changes only one CI YAML file and replaces the sync-rover-groups image base. It adds no Ginkgo e2e tests, test declarations, OpenShift API references, namespaces, or MicroShift assu…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It changes the sync-rover-groups image base and removes package installation. It adds no Gin…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It changes the sync-rover-groups image base and removes package installation commands. It do…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only the sync-rover-groups container image declaration in ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It changes the base image and removes p…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It changes the sync-rover-groups image base and removes package installation. It adds no Gin…
No-Weak-Crypto ✅ Passed PASS. The authoritative PR diff changes only the sync-rover-groups container base image and removes package installation. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or…
Container-Privileges ✅ Passed The pull request changes only the sync-rover-groups image base and removes package-install commands. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivile…
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only the sync-rover-groups image base in ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml. It replaces the UBI Minimal base and package-install step with the RHEL …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@hector-vido
hector-vido force-pushed the certs-for-sync-rover-groups branch from 951b8d3 to e178f6f Compare September 16, 2026 13:51
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA 2d39333433a0b615b83bea2e1ec2afa352175f84: error checking out "2d39333433a0b615b83bea2e1ec2afa352175f84": exit status 128 fatal: unable to read tree (2d39333433a0b615b83bea2e1ec2afa352175f84)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-ci-tools-main-images

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hector-vido

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 415180a into openshift:main Sep 16, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants