Skip to content

prow: remove jira/valid-bug requirement for k8s-prometheus-adapter 4.15+ - #85301

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:remove-valid-bug-prometheus-adapter
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:remove-valid-bug-prometheus-adapter

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Summary

Remove the jira/valid-bug label requirement from Tide merge queries for openshift/k8s-prometheus-adapter on branches release-4.15 through release-4.22 (and their openshift-4.x counterparts, plus 5.0).

Motivation

The prometheus-adapter component was removed from the OCP payload starting in 4.16. Starting from release-4.15, parent Jira trackers cannot provide valid bug references for CVE fix PRs, causing the jira/invalid-bug label to block merges.

Changes

Edited both openshift and openshift-priv Tide configs:

  • Removed release-4.15 through release-4.22, openshift-4.15 through openshift-4.22, and 5.x entries from the query block that requires jira/valid-bug
  • Removed the same branches from the catch-all query's excludedBranches so they fall through to the catch-all (which does not require jira/valid-bug)

Files Changed

  • core-services/prow/02_config/openshift/k8s-prometheus-adapter/_prowconfig.yaml
  • core-services/prow/02_config/openshift-priv/k8s-prometheus-adapter/_prowconfig.yaml

AI-generated. Review for accuracy.

@machine424 requested via Chai Bot

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 0858a257-f7f7-41ba-b130-7321ec63a991

📥 Commits

Reviewing files that changed from the base of the PR and between f21caf5 and 65986f5.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift-priv/k8s-prometheus-adapter/_prowconfig.yaml
  • core-services/prow/02_config/openshift/k8s-prometheus-adapter/_prowconfig.yaml

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@redhat-chai-bot
redhat-chai-bot force-pushed the remove-valid-bug-prometheus-adapter branch from 297528f to 65986f5 Compare September 16, 2026 13:37
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@simonpasquier simonpasquier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 91c1f8e into openshift:main Sep 16, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-priv-k8s-prometheus-adapter-_prowconfig.yaml using file core-services/prow/02_config/openshift-priv/k8s-prometheus-adapter/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-k8s-prometheus-adapter-_prowconfig.yaml using file core-services/prow/02_config/openshift/k8s-prometheus-adapter/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-priv-k8s-prometheus-adapter-_prowconfig.yaml using file core-services/prow/02_config/openshift-priv/k8s-prometheus-adapter/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-k8s-prometheus-adapter-_prowconfig.yaml using file core-services/prow/02_config/openshift/k8s-prometheus-adapter/_prowconfig.yaml
Details

In response to this:

Summary

Remove the jira/valid-bug label requirement from Tide merge queries for openshift/k8s-prometheus-adapter on branches release-4.15 through release-4.22 (and their openshift-4.x counterparts, plus 5.0).

Motivation

The prometheus-adapter component was removed from the OCP payload starting in 4.16. Starting from release-4.15, parent Jira trackers cannot provide valid bug references for CVE fix PRs, causing the jira/invalid-bug label to block merges.

Changes

Edited both openshift and openshift-priv Tide configs:

  • Removed release-4.15 through release-4.22, openshift-4.15 through openshift-4.22, and 5.x entries from the query block that requires jira/valid-bug
  • Removed the same branches from the catch-all query's excludedBranches so they fall through to the catch-all (which does not require jira/valid-bug)

Files Changed

  • core-services/prow/02_config/openshift/k8s-prometheus-adapter/_prowconfig.yaml
  • core-services/prow/02_config/openshift-priv/k8s-prometheus-adapter/_prowconfig.yaml

AI-generated. Review for accuracy.

@machine424 requested via Chai Bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants