Conversation
Keep the DEV CAPZ job compatible when ARO-HCP enables weighted region selection by explicitly overriding its slot-manager location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe CAPZ e2e ChangesCAPZ e2e configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The configuration change is narrowly scoped to the intended DEV deployment-location override and is ready to merge. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse pull-ci-Azure-ARO-HCP-main-capz-e2e-dev |
|
@RadekCap: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzazrivec, roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehease ack |
|
@roivaz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@marek-veber: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The ARO HCP CAPZ DEV job acquires infrastructure through slot-manager but only sets
LOCATION, which slot-manager does not consume. ARO-HCP pull request Azure/ARO-HCP#6898 changes the DEV pool to weighted region selection and requires either weighted inputs or an explicit location override.Set
MULTISTAGE_PARAM_OVERRIDE_LOCATION=westus3so this job remains pinned and can roll out independently without downtime. KeepLOCATIONbecause the shared CAPZ steps still consume it directly.Related: Azure/ARO-HCP#6898
Summary by CodeRabbit
The ARO HCP CAPZ DEV CI job now sets
MULTISTAGE_PARAM_OVERRIDE_LOCATION=westus3for the slot manager. It retainsLOCATION=westus3for shared CAPZ steps. This supports weighted region selection in the DEV pool.