Skip to content

ARO HCP: pin CAPZ DEV slot-manager location - #85295

Open
roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:multi-region-dev-e2e
Open

roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:multi-region-dev-e2e

Conversation

@roivaz

@roivaz roivaz commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

The ARO HCP CAPZ DEV job acquires infrastructure through slot-manager but only sets LOCATION, which slot-manager does not consume. ARO-HCP pull request Azure/ARO-HCP#6898 changes the DEV pool to weighted region selection and requires either weighted inputs or an explicit location override.

Set MULTISTAGE_PARAM_OVERRIDE_LOCATION=westus3 so this job remains pinned and can roll out independently without downtime. Keep LOCATION because the shared CAPZ steps still consume it directly.

Related: Azure/ARO-HCP#6898

Summary by CodeRabbit

The ARO HCP CAPZ DEV CI job now sets MULTISTAGE_PARAM_OVERRIDE_LOCATION=westus3 for the slot manager. It retains LOCATION=westus3 for shared CAPZ steps. This supports weighted region selection in the DEV pool.

Keep the DEV CAPZ job compatible when ARO-HCP enables weighted region selection by explicitly overriding its slot-manager location.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b4a6268b-6406-4194-b29c-9c80d68648b6

📥 Commits

Reviewing files that changed from the base of the PR and between 92ea7cd and 9440c36.

📒 Files selected for processing (1)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The CAPZ e2e dev job now sets MULTISTAGE_PARAM_OVERRIDE_LOCATION to westus3.

Changes

CAPZ e2e configuration

Layer / File(s) Summary
Dev deployment location override
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml
The dev job step environment adds MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: marek-veber

Merge Risk: ⚪ Minimal · up to 9440c

The configuration change is narrowly scoped to the intended DEV deployment-location override and is ready to merge.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the ARO HCP change and the specific action of pinning the CAPZ DEV slot-manager location. It matches the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes one file and adds only MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 to the CI environment. No Ginkgo test declarations or test titles changed, so no unstable test name …
Test Structure And Quality ✅ Passed PASS: The pull request changes only one CI YAML file and adds the MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 environment variable. It does not add or modify Ginkgo test code, It blocks, fixtures,…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only one CI YAML file and adds MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 to the existing dev job. The diff adds no Ginkgo tests, OpenShift API references, namespac…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one CI YAML file. It adds the MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 environment variable and adds no Ginkgo tests or test code. The SNO compatibility check is the…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml. The diff adds the CI environment variable MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 to the…
Ote Binary Stdout Contract ✅ Passed The pull request changes only one YAML CI configuration file. It adds MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 to the dev job. The authoritative diff contains no Go files, OTE binary code, suit…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only the CAPZ CI YAML configuration. It adds MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 and adds no Ginkgo tests or test networking behavior. Therefore, the IPv4 and …
No-Weak-Crypto ✅ Passed PASS: The pull request changes one CI YAML file and adds only MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3 to the dev job. The diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cr…
Container-Privileges ✅ Passed PASS: The pull request changes only one CI environment variable, MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3. The authoritative diff introduces no privileged, host namespace, SYS_ADMIN, or `allo…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only the CAPZ DEV job configuration by adding MULTISTAGE_PARAM_OVERRIDE_LOCATION: westus3. The value is a public Azure region, not a password, token, API key, PII, ses…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deads2k and mmazur September 16, 2026 12:59
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@roivaz: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-Azure-ARO-HCP-main-capz-e2e-dev Azure/ARO-HCP presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mzazrivec

Copy link
Copy Markdown
Member

/lgtm

@RadekCap

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-Azure-ARO-HCP-main-capz-e2e-dev

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekCap: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzazrivec, roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RadekCap

Copy link
Copy Markdown
Contributor

/pj-rehease ack

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@roivaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marek-veber

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@marek-veber: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants