Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughChangesCNF features deploy CI configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR only makes AWS E2E tests opt-in on the specified release branches; no concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
Set always_run: false for the e2e-aws-ci-tests presubmit on the release-4.12 through release-4.18 branches so it no longer runs automatically, matching the opt-in behavior already in place on master and release-4.19 through 5.0. Signed-off-by: Tomer Avital <tavital@redhat.com>
78e5a5e to
6e6ff57
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
| secret: | ||
| secretName: result-aggregator | ||
| trigger: (?m)^/test( | .* )e2e-aws-ci-tests,?($|\s.*) | ||
| trigger: (?m)^/test( | .* )(e2e-aws-ci-tests|remaining-required),?($|\s.*) |
There was a problem hiding this comment.
what is "remaining-required" addition ?
|
/lgtm |
|
/pj-rehearse ack |
|
@tavital: your |
|
/pj-rehearse |
|
@tavital: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tavital, yanirq The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tavital: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Fix auto run
e2e-aws-ci-testsfor release-4.12 to release-4.18 versions.Set always_run: false for the e2e-aws-ci-tests presubmit on the release-4.12 through release-4.18 branches so it no longer runs automatically, matching the opt-in behavior already in place on master and release-4.19 through 5.0.
Summary by CodeRabbit
Updated
e2e-aws-ci-testsin theopenshift-kni/cnf-features-deployCI configuration for release-4.12 through release-4.18.The test now uses
always_run: false, so it no longer runs automatically for every change. This aligns these release branches with the existing configuration on master and later release branches.