Skip to content

ci: enable ARO HCP sweeper tags - #85286

Open
marek-veber wants to merge 1 commit into
openshift:mainfrom
marek-veber:fix/aro-29646-sweeper-tags
Open

marek-veber wants to merge 1 commit into
openshift:mainfrom
marek-veber:fix/aro-29646-sweeper-tags

Conversation

@marek-veber

@marek-veber marek-veber commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Enable ARO_HCP_SWEEPER_TAGS=true for the CAPZ PROD job in Azure-ARO-HCP-main__capz-e2e.yaml.

The CAPZ DEV job already had this variable; this change adds it only to the PROD job. The management-cluster-only stolostron/capi-tests Prow configs are intentionally unchanged.

Related Jira: ARO-29646

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2026
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b88d4c50-bfaf-4c22-b302-2c8dd5f234e5

📥 Commits

Reviewing files that changed from the base of the PR and between b555c28 and 30048af.

📒 Files selected for processing (3)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml
  • ci-operator/config/stolostron/capi-tests/stolostron-capi-tests-configure-prow-mgmt.yaml
  • ci-operator/config/stolostron/capi-tests/stolostron-capi-tests-configure-prow-mgmt__periodics.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The PR sets ARO_HCP_SWEEPER_TAGS to "true" in three capz-e2e CI configurations.

Changes

Sweeper tag configuration

Layer / File(s) Summary
Configure sweeper tags
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__capz-e2e.yaml, ci-operator/config/stolostron/capi-tests/stolostron-capi-tests-configure-prow-mgmt*.yaml
The production, test, and periodic capz-e2e configurations set ARO_HCP_SWEEPER_TAGS to "true".

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to 30048

The CI configurations enable the requested sweeper-tag behavior consistently, so the change is ready to merge.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check passes. The pull request changes only three YAML environment blocks and adds ARO_HCP_SWEEPER_TAGS: "true"; the authoritative diff contains no It, Describe, Context, or When test-ti…
Test Structure And Quality ✅ Passed PASS: The pull request changes only three CI YAML files by adding ARO_HCP_SWEEPER_TAGS: "true". The authoritative diff contains no Ginkgo test code or changed test structure, setup, cleanup, waits, …
Microshift Test Compatibility ✅ Passed PASS: The authoritative pull-request diff changes only three CI YAML files and adds ARO_HCP_SWEEPER_TAGS: "true" to existing job environment blocks. It adds no Ginkgo tests (It, Describe, `Conte…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only three YAML CI configurations. Each change adds ARO_HCP_SWEEPER_TAGS: "true". The authoritative diff contains no new Ginkgo tests or test declarations, so the SNO …
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes only three CI operator YAML files. Each added line sets ARO_HCP_SWEEPER_TAGS: "true" in a Prow test environment. The referenced step documents this variable as adding …
Ote Binary Stdout Contract ✅ Passed PASS: The review-scoped diff changes only three YAML CI configuration files. Each added line sets ARO_HCP_SWEEPER_TAGS: "true" in a job environment. No Go or other executable source changed, and the…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only three YAML CI configuration files. Each change adds ARO_HCP_SWEEPER_TAGS: "true" to an existing job environment block. The diff adds no Ginkgo tests, networking c…
No-Weak-Crypto ✅ Passed PASS. The pull request adds only ARO_HCP_SWEEPER_TAGS: "true" to three CI YAML environment blocks. The added lines do not use MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom cryptography, or s…
Container-Privileges ✅ Passed The pull request only adds ARO_HCP_SWEEPER_TAGS: "true" to three CI test env blocks. The authoritative diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowPrivilegeE…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request adds only ARO_HCP_SWEEPER_TAGS: "true" to three CI job environment blocks. This is a boolean control for adding cleanup tags to resource groups, not a password, token, API key…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling ARO HCP sweeper tags in CI configurations.
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/aro-29646-sweeper-tags
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@marek-veber, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto b555c286b13cc3c23b30f3bffe6fde2c18e31e84 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
openshift-ci Bot requested review from mzazrivec and raelga September 16, 2026 11:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@marek-veber
marek-veber force-pushed the fix/aro-29646-sweeper-tags branch from 30048af to 1ba4458 Compare September 16, 2026 12:04

@RadekCap RadekCap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marek-veber, RadekCap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@marek-veber, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 33e50842da7a07dee3ad8be328c2dcd479e60456 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@marek-veber
marek-veber force-pushed the fix/aro-29646-sweeper-tags branch from 1ba4458 to 8354b06 Compare September 16, 2026 13:17
@openshift-ci openshift-ci Bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. lgtm Indicates that a PR is ready to be merged. labels Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@marek-veber: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@marek-veber
marek-veber force-pushed the fix/aro-29646-sweeper-tags branch from 8354b06 to 45dd5a1 Compare September 16, 2026 13:23
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@marek-veber: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-Azure-ARO-HCP-main-capz-e2e-production N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@marek-veber: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants