[PERFSCALE-5825] Enable Regulus Dataplane Testsuite on existing BM CPT Lab for Telco Core RDS

[sraviteja-maker]

Summary by CodeRabbit

The daily-telco-core-6nodes job in the BM CPT Lab configuration now includes the Regulus Dataplane Testsuite. It runs openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus alongside the existing Telco Core RDS tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: f1973167-0786-41cb-89c0-cb5dbd19283d

📥 Commits

Reviewing files that changed from the base of the PR and between 1cfdde1 and f632dd1.

📒 Files selected for processing (1)

• ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__metal-5.0-nightly-x86.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The daily-telco-core-6nodes job now runs the Regulus installer and Orion test references in addition to its existing test steps.

Changes

Telco Core Regulus Integration

Layer / File(s)	Summary
Add Regulus test references ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__metal-5.0-nightly-x86.yaml	The daily-telco-core-6nodes test sequence adds openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus at the specified positions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: masco

Merge Risk: ⚪ Minimal · up to f632d

The added Regulus references resolve to existing steps, with no identified merge-blocking risk.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	The PR adds openshift-qe-installer-bm-regulus to daily-telco-core-6nodes, so this job now runs the existing Regulus installer script. That script enables set -x at line 22 and executes commands …	Remove the unconditional set -x, or disable tracing before all commands and diagnostics that contain bastion or TRUE_BASTION_HOST. Keep tracing disabled while handling credentials and lab.config. If diagnostics are required, log onl…
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	The pull request adds openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus to the daily-telco-core-6nodes job. These steps require public GitHub access: the installer clones `https:/…	IPv6 and disconnected network compatibility notice: This test may contain IPv4 assumptions or external connectivity requirements that will fail in IPv6-only disconnected environments. Please verify your test works on IPv6 by running an …

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only one CI YAML file and adds two static step references: openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus. It does not add or modify any Ginkgo It(), `…
Test Structure And Quality	✅ Passed	PASS. The PR changes only one CI YAML file and adds two existing step refs to daily-telco-core-6nodes. The diff contains no Ginkgo test code, It blocks, setup/cleanup logic, cluster waits, or asse…
Microshift Test Compatibility	✅ Passed	The pull request changes only one YAML CI configuration file. It adds two existing CI step references to daily-telco-core-6nodes; it does not add or modify Ginkgo tests, test names, or test bodies. …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only one YAML CI configuration file. It adds two existing test-step references, openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus, to `daily-telco-core-6nod…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The pull request changes only one CI configuration file. Its two added lines reference existing test steps, openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus. The diff adds no…
Ote Binary Stdout Contract	✅ Passed	PASS: The reviewed range changes only one YAML job and adds two existing step references. It does not change an OTE binary or any process-level Go setup. The referenced Regulus step definitions and co…
No-Weak-Crypto	✅ Passed	The pull request changes one YAML file and adds only two test-step references: openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus. The patch contains no MD5, SHA1, DES, RC4, 3DES, Bl…
Container-Privileges	✅ Passed	The pull request adds only two test-step references: openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus. The added lines contain none of the checked privilege settings. The changed j…
Title check	✅ Passed	The title clearly and specifically describes the main change: enabling the Regulus Dataplane Testsuite for Telco Core RDS on the existing BM CPT Lab.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

The pull request adds openshift-qe-installer-bm-regulus and openshift-qe-orion-regulus to the daily-telco-core-6nodes job. These steps require public GitHub access: the installer clones https://github.com/redhat-performance/regulus.git, and the Orion step clones the Regulus and Orion GitHub repositories and installs Python dependencies. This activation causes an external-connectivity requirement in disconnected jobs. No new hardcoded IPv4 address was found.

Resolution

IPv6 and disconnected network compatibility notice: This test may contain IPv4 assumptions or external connectivity requirements that will fail in IPv6-only disconnected environments. Please verify your test works on IPv6 by running an additional CI job: For parallel tests: /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6 For serial tests (test name contains [Serial]): /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-serial-ovn-ipv6 Use internal mirrors for the Regulus and Orion repositories and Python dependencies, or skip these steps in disconnected jobs with the repository's disconnected-test mechanism.

Full details: No-Sensitive-Data-In-Logs

Explanation

The PR adds openshift-qe-installer-bm-regulus to daily-telco-core-6nodes, so this job now runs the existing Regulus installer script. That script enables set -x at line 22 and executes commands containing root@${bastion} and ${TRUE_BASTION_HOST}. It loads the bastion address from CLUSTER_PROFILE_DIR/address and discovers the true bastion host, so shell tracing can write internal host values to the job log. The script protects Elasticsearch credentials by disabling tracing while it reads and writes them, but it does not disable tracing around the host-bearing SSH and SCP commands. The PR therefore activates a logging path that can expose internal hostnames.

Resolution

Remove the unconditional set -x, or disable tracing before all commands and diagnostics that contain bastion or TRUE_BASTION_HOST. Keep tracing disabled while handling credentials and lab.config. If diagnostics are required, log only fixed messages or sanitized host identifiers.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sraviteja-maker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@sraviteja-maker: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.
The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
periodic-ci-openshift-eng-ocp-perfscale-main-metal-5.0-nightly-x86-daily-telco-core-6nodes

[openshift-ci]

@sraviteja-maker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[arpsharm]

/pj-rehearse network-access-allowed

[openshift-merge-bot]

@arpsharm: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[sraviteja-maker]

/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-metal-5.0-nightly-x86-daily-telco-core-6nodes

[openshift-merge-bot]

@sraviteja-maker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@sraviteja-maker, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout base SHA 92ea7cd46a99d1d27a12c4da1b278091db64f061: error checking out "92ea7cd46a99d1d27a12c4da1b278091db64f061": exit status 128 fatal: unable to read tree (92ea7cd46a99d1d27a12c4da1b278091db64f061)

[sraviteja-maker]

/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-metal-5.0-nightly-x86-daily-telco-core-6nodes

[openshift-merge-bot]

@sraviteja-maker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[sraviteja-maker]

/pj-rehearse abort

[openshift-merge-bot]

@sraviteja-maker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.