Skip to content

bind cluster-secrets-devsandboxci-aws collection to devsandbox-aws ro… - #85281

Open
jrosental wants to merge 2 commits into
openshift:mainfrom
jrosental:add-cluster-secrets-devsandboxci-aws-collection-to-rover-group
Open

jrosental wants to merge 2 commits into
openshift:mainfrom
jrosental:add-cluster-secrets-devsandboxci-aws-collection-to-rover-group

Conversation

@jrosental

@jrosental jrosental commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

…ver group

Summary by CodeRabbit

The configuration grants the devsandbox-aws Rover group access to the cluster-secrets-devsandboxci-aws collection. This enables the group to use the AWS secrets required by devsandbox CI.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrosental
Once this PR has been reviewed and has the lgtm label, please assign prucek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: ce95fed1-fc22-447f-a291-7d746bcb1588

📥 Commits

Reviewing files that changed from the base of the PR and between 2b498a9 and a4d624d.

📒 Files selected for processing (1)
  • core-services/sync-rover-groups/_config.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The configuration assigns cluster-secrets-devsandboxci-aws to the new devsandbox-aws group under cvp-pool-admins and removes it from test-platform-gsm-unclaimed-secrets.

Changes

Secret collection ownership

Layer / File(s) Summary
Assign secret collection ownership
core-services/sync-rover-groups/_config.yaml
Adds the devsandbox-aws group with cluster-secrets-devsandboxci-aws and removes the same collection from the unclaimed secrets group.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to a4d62

The change is limited to the intended secret collection ownership reassignment and presents no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: binding the cluster-secrets-devsandboxci-aws collection to the devsandbox-aws Rover group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only core-services/sync-rover-groups/_config.yaml (+3/-1). It adds a static secret-collection mapping and removes one static list entry. It does not add or modify Ginkgo tes…
Test Structure And Quality ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds the secret collection to devsandbox-aws and removes it from the unclaimed group. The changed directory con…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds a Rover secret collection binding and removes the collection from an unclaimed-secrets group. It adds no Gin…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds a Rover group secret-collection binding and removes the collection from an unclaimed-secrets list. It adds n…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The authoritative diff changes only core-services/sync-rover-groups/_config.yaml. It adds the cluster-secrets-devsandboxci-aws collection to the devsandbox-aws Rover group and removes it f…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. The patch adds a secret collection mapping and removes the same collection from an unclaimed group. It changes no OT…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds a Rover group-to-secret collection binding and removes one unclaimed-secret entry. The reviewed range adds n…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds the devsandbox-aws group binding and removes the collection from the unclaimed group. The added and remove…
Container-Privileges ✅ Passed The pull request changes only core-services/sync-rover-groups/_config.yaml. It adds a Rover group-to-secret-collection binding and removes the collection from an unclaimed-secrets list. It introduce…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only _config.yaml. It adds the cluster-secrets-devsandboxci-aws collection to the devsandbox-aws group and removes it from the unclaimed group. The diff adds no logging,…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Prucek and jmguzik September 16, 2026 10:34
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jrosental: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@jrosental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant