Conversation
Use the `test-credentials` namespace for the RHCOS 9 and RHCOS 10 build tests as without it the tests are failing and blocking CI. ref: coreos/rhel-coreos-config#324
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe RHEL CoreOS 9 and 10 build test steps now set ChangesRHEL CoreOS test credential namespaces
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The credential namespace updates match the stated CI test objective and are ready to merge. 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-coreos-rhel-coreos-config-main-rhcos-10-build-test |
|
@jbtrystram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram, Roshan-R The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-coreos-rhel-coreos-config-main-rhcos-9-build-test |
|
@jbtrystram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Roshan-R: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Use the
test-credentialsnamespace for the RHCOS 9 and RHCOS 10 build tests as without it the tests are failing and blocking CI.ref: coreos/rhel-coreos-config#324
Summary by CodeRabbit
The RHCOS 9 and RHCOS 10 build tests now use pull credentials from the
test-credentialsnamespace. This fixes credential lookup failures that block OpenShift CI.