DNM: swap to rhel 8 for testing - #82644
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughOMR v2 provisioning now selects official RHEL 8 hourly AMIs and updates the health-check curl command for curl versions available on RHEL 8. ChangesRHEL 8 compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-quay-quay-master-omr-v2-upgrade-v3-disconnected-install |
|
@jbpratt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/quay/omr-v2/host-provision/quay-omr-v2-host-provision-commands.sh`:
- Line 105: Update the documentation in the host-provision step reference for
OMR_V2_AMI_ID and the provisioned host to state RHEL 8 instead of RHEL 9,
ensuring explicit AMI inputs and generated guidance match the RHEL 8 discovery
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 345f9648-bfcf-4c21-b89b-929a94396aa2
📒 Files selected for processing (1)
ci-operator/step-registry/quay/omr-v2/host-provision/quay-omr-v2-host-provision-commands.sh
| --owners 309956199498 \ | ||
| --filters \ | ||
| 'Name=name,Values=RHEL-9.*_HVM-*-x86_64-*-Hourly2-GP3' \ | ||
| 'Name=name,Values=RHEL-8.*_HVM-*-x86_64-*-Hourly2-GP3' \ |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Update the step contract to RHEL 8.
The script now discovers RHEL 8 AMIs, but ci-operator/step-registry/quay/omr-v2/host-provision/quay-omr-v2-host-provision-ref.yaml still documents OMR_V2_AMI_ID and the provisioned host as RHEL 9. Update that file’s documentation to RHEL 8 so explicit AMI inputs and generated guidance match the new behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/quay/omr-v2/host-provision/quay-omr-v2-host-provision-commands.sh`
at line 105, Update the documentation in the host-provision step reference for
OMR_V2_AMI_ID and the provisioned host to state RHEL 8 instead of RHEL 9,
ensuring explicit AMI inputs and generated guidance match the RHEL 8 discovery
behavior.
|
/label wip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbpratt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@jbpratt: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
|
/label do-not-merge/work-in-progress |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@jbpratt: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jbpratt: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Brady Pratt <bpratt@redhat.com>
|
/pj-rehearse periodic-ci-quay-quay-master-omr-v2-upgrade-v3-disconnected-install |
|
@jbpratt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
2 participants
Summary by CodeRabbit
Updates OpenShift CI’s Quay OMR v2 disconnected install testing to use official RHEL 8 hourly AWS AMIs for the dedicated host provisioning (including the AMI resolution failure message). It also adjusts the OMR v2 health-check command used during the install step to drop
curl --retry-all-errors(not supported on RHEL 8 curl), while keeping the existing retry behavior.