Skip to content

Add kserve-module-controller image dependency to kserve e2e test for master - #82638

Open
Jooho wants to merge 1 commit into
openshift:mainfrom
Jooho:enable_km_for_e2e
Open

Add kserve-module-controller image dependency to kserve e2e test for master#82638
Jooho wants to merge 1 commit into
openshift:mainfrom
Jooho:enable_km_for_e2e

Conversation

@Jooho

@Jooho Jooho commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Wires KSERVE_MODULE_CONTROLLER_IMAGE (kserve-module-controller) into the kserve e2e tests so they can pull the module controller image.

Covers raw / rawcipn / predictor / llm-d tests in both opendatahub-io-kserve-master.yaml and opendatahub-io-kserve-release-v0.17.yaml.

Config-only dependency addition, no generated job changes.

Summary by CodeRabbit

Adds the kserve-module-controller image dependency to KServe end-to-end CI tests across raw, rawcipn, predictor, and llm-d configurations for master and release v0.17. This ensures the affected OpenShift CI jobs can access the module controller image without changing generated job logic.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 51927b02-447a-4585-921f-0f901780cc4f

📥 Commits

Reviewing files that changed from the base of the PR and between 5442b22 and cae5b9b.

📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/kserve/opendatahub-io-kserve-master.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/opendatahub-io/kserve/opendatahub-io-kserve-master.yaml

Walkthrough

The KServe CI configuration adds the KSERVE_MODULE_CONTROLLER_IMAGE environment mapping to four hypershift-based E2E jobs: graph, raw, predictor, and LLM inference service.

Changes

KServe E2E image wiring

Layer / File(s) Summary
Add module controller image to E2E jobs
ci-operator/config/opendatahub-io/kserve/opendatahub-io-kserve-master.yaml
The graph, raw, predictor, and LLM inference service jobs now map KSERVE_MODULE_CONTROLLER_IMAGE to kserve-module-controller.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: vivekk16, mholder6

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding the kserve-module-controller image dependency to KServe e2e tests on master.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only CI YAML dependencies; no Ginkgo test titles or test code were modified.
Test Structure And Quality ✅ Passed Config-only PR: only the KServe master ci-operator YAML changed, adding image deps; no Ginkgo test code or test structure to assess.
Microshift Test Compatibility ✅ Passed Only CI YAML dependency entries changed; no new Ginkgo tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo tests were added; the PR only wires a CI image dependency in YAML, so SNO compatibility isn't impacted.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator test image dependencies changed; no manifests/controllers, node selectors, affinity, spread, or replica logic were added.
Ote Binary Stdout Contract ✅ Passed PR only adds a YAML image dependency; no OTE process-level stdout writes or code changes are present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Config-only image dependency wiring; no new Ginkgo tests or IPv4/external-network logic were added.
No-Weak-Crypto ✅ Passed Changed KServe CI YAMLs only add KSERVE_MODULE_CONTROLLER_IMAGE deps; no weak crypto tokens or custom secret comparisons are present.
Container-Privileges ✅ Passed PR only adds KServe image dependencies; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings appear in changed files.
No-Sensitive-Data-In-Logs ✅ Passed The change only adds an image dependency in CI config and introduces no new logging or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from mholder6 and vivekk16 July 29, 2026 17:43
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
Wires KSERVE_MODULE_CONTROLLER_IMAGE into the raw/rawcipn/predictor/llm-d
e2e tests for the master config.

Signed-off-by: Jooho Lee <jlee@redhat.com>
@Jooho Jooho changed the title Add kserve-module-controller image dependency to kserve e2e tests Add kserve-module-controller image dependency to kserve e2e test for master Jul 29, 2026
@Jooho
Jooho force-pushed the enable_km_for_e2e branch from 5442b22 to cae5b9b Compare July 29, 2026 17:55
@Jooho

Jooho commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Jooho: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jooho: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-kserve-master-e2e-graph opendatahub-io/kserve presubmit Ci-operator config changed
pull-ci-opendatahub-io-kserve-master-e2e-llm-inference-service opendatahub-io/kserve presubmit Ci-operator config changed
pull-ci-opendatahub-io-kserve-master-e2e-predictor opendatahub-io/kserve presubmit Ci-operator config changed
pull-ci-opendatahub-io-kserve-master-e2e-raw opendatahub-io/kserve presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@Jooho: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/kserve/master/e2e-raw cae5b9b link unknown /pj-rehearse pull-ci-opendatahub-io-kserve-master-e2e-raw
ci/rehearse/opendatahub-io/kserve/master/e2e-graph cae5b9b link unknown /pj-rehearse pull-ci-opendatahub-io-kserve-master-e2e-graph
ci/rehearse/opendatahub-io/kserve/master/e2e-predictor cae5b9b link unknown /pj-rehearse pull-ci-opendatahub-io-kserve-master-e2e-predictor
ci/rehearse/opendatahub-io/kserve/master/e2e-llm-inference-service cae5b9b link unknown /pj-rehearse pull-ci-opendatahub-io-kserve-master-e2e-llm-inference-service

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant