ci: point terraform-provider-rhcs at staged build/ CI Dockerfiles - #82637
ci: point terraform-provider-rhcs at staged build/ CI Dockerfiles#82637amandahla wants to merge 1 commit into
Conversation
Activate project_image build_root and clients image paths staged in terraform-provider-rhcs#1271 so Snyk can use ubi9/go-toolset:1.26.5. Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThe CI operator configuration replaces repository-based build-root selection with an explicit Dockerfile and changes the client image to use ChangesTerraform provider CI image configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse pull-ci-terraform-redhat-terraform-provider-rhcs-main-images pull-ci-terraform-redhat-terraform-provider-rhcs-main-pre-push-checks pull-ci-terraform-redhat-terraform-provider-rhcs-main-security |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 45 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amandahla: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Perfect, now Synk is scanning again and failed due security issue found. |
|
/lgtm |
|
/pj-rehease ack |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, jerichokeyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
terraform-provider-rhcsmain ci-operator config frombuild_root.from_repository+ rootDockerfile.clientsto the paths staged in terraform-redhat/terraform-provider-rhcs#1271:build_root.project_image.dockerfile_path: build/custom-ci-build-root.Dockerfile(ubi9/go-toolset:1.26.5+git/jqfor Snyk)images.items[].dockerfile_path: build/Dockerfile.ciWhy
Optional
ci/prow/security(Snyk) runs on thesrcimage frombuild_root. Withfrom_repository: true, Go patch selection is limited to the ImageStream tag.project_imageunlocks the staged Go 1.26.5 toolset image.Test plan
/pj-rehearsepull-ci-terraform-redhat-terraform-provider-rhcs-main-images/pj-rehearsepull-ci-terraform-redhat-terraform-provider-rhcs-main-pre-push-checks/pj-rehearsepull-ci-terraform-redhat-terraform-provider-rhcs-main-security(confirm Go toolset / Snyk env)from_repository+build/ci-tf-e2e.Dockerfile(unchanged)Follow-up (provider repo)
After this merges: remove unused root
Dockerfile.clientsand revisit.ci-operator.yamloncefrom_repositoryis unused on main.Made with Cursor
Summary by CodeRabbit
Updates the
terraform-provider-rhcsmain CI pipeline to build its project and client images from the staged Dockerfiles, enabling Snyk jobs to use theubi9/go-toolset:1.26.5environment with required tooling. E2E variants continue using their repository-based image configuration.