coreos/coreos-assembler: use fedora:latest build_root image - #82629
coreos/coreos-assembler: use fedora:latest build_root image#82629dustymabe wants to merge 1 commit into
Conversation
|
/pj-rehearse auto-ack |
|
@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe CoreOS assembler CI configuration now uses Fedora latest as its build root, installs only ChangesCoreOS assembler build configuration
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use a moving tag for the build_root image so we never have to update it again and also stop using this build_root image to replace the FROM in the Dockerfile [1] since there is really no need and it means we have to update two places when we actually update the Dockerfile to a new Fedora version. This also drops the findutils RPM add. As far as AI and I could tell this is not a documented requirement and we couldn't find any git history reasoning on why this is actually required. Let's find out! [1] https://github.com/coreos/coreos-assembler/blob/0ace2f67a9cb1b0495cc0ecd06bc9ba4c0e7bc1d/Dockerfile#L3
dd697c0 to
f9e3d9e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/coreos/coreos-assembler/coreos-coreos-assembler-main.yaml`:
- Around line 4-9: Replace the mutable FROM image in the coreos-assembler
build-root definition with a tested, immutable Fedora release or digest. Keep
the existing git installation and build-root requirements unchanged, and ensure
future image updates occur through controlled, reviewable changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b83b5cb6-7ec9-498a-aa00-c67a7769df46
📒 Files selected for processing (1)
ci-operator/config/coreos/coreos-assembler/coreos-coreos-assembler-main.yaml
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
c4rt0
left a comment
c4rt0
left a comment
There was a problem hiding this comment.
Thanks for this, it is much better indeed. No more bumping the Fedora version every release in here.
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4rt0, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@dustymabe: your |
|
/pj-rehearse auto-ack |
|
@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dustymabe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Use a moving tag for the build_root image so we never have to update it again and also stop using this build_root image to replace the FROM in the Dockerfile [1] since there is really no need and it means we have to update two places when we actually update the Dockerfile to a new Fedora version.
This also drops the findutils RPM add. As far as AI and I could tell this is not a documented requirement and we couldn't find any git history reasoning on why this is actually required. Let's find out!
[1] https://github.com/coreos/coreos-assembler/blob/0ace2f67a9cb1b0495cc0ecd06bc9ba4c0e7bc1d/Dockerfile#L3
Summary by CodeRabbit
Updates the CoreOS assembler CI build configuration in
openshift/releaseto use the movingquay.io/fedora/fedora:latesttag for thebuild_rootimage (so it no longer needs periodic Fedora version bumps), simplifies the build root to install onlygitand create a writable/godirectory, and stops overriding the Dockerfile’sFROM(by removing thefrom: rootbehavior) to avoid duplicate Fedora version updates.