WINC-2015: Disable platform monitors in aws-e2e-ote job

[rrasouli]

Problem

The aws-e2e-ote job uses the openshift-e2e-test step which runs openshift-tests run with platform monitors enabled. These monitors scan all namespaces for invariant violations and cause false failures completely unrelated to OTE extension tests.

The OTE tests themselves all pass (8 pass, 1 skip), but 10 monitor failures cause the overall job to fail:

• termination-message-policy -- flags pods in openshift-windows-machine-config-operator namespace
• required-scc-annotation-checker -- flags pods missing SCC annotations
• pod-network-avalibility -- network availability checks across all namespaces
• kubelet-log-collector -- kubelet log collection invariant checks

Fix

Add TEST_ARGS: --disable-monitor=... to disable these 4 specific monitors in the aws-e2e-ote job. This follows the same pattern used by openshift-e2e-aws-csi-smb-win (another Windows test job) which already disables pod-network-avalibility and required-scc-annotation-checker.

Change

One line added to ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml:

TEST_ARGS: --disable-monitor=pod-network-avalibility,required-scc-annotation-checker,termination-message-policy,kubelet-log-collector

Summary by CodeRabbit

• Updates the Windows Machine Config Operator’s aws-e2e-ote CI job to disable unrelated platform monitors that scan all namespaces and can cause false failures in WMCO namespaces.
• Keeps OTE extension testing focused by disabling the specified monitor checks, including network availability, SCC annotations, termination-message policy, and kubelet log collection.

[openshift-ci-robot]

@rrasouli: This pull request references WINC-2015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The openshift-e2e-test step runs platform monitors that scan all namespaces for invariant violations. These monitors are unrelated to OTE extension tests and cause false failures in the aws-e2e-ote job. Disable the specific monitors that fire on WMCO namespaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The Windows machine config adds a TEST_ARGS environment variable to the aws-e2e-ote job, disabling four specified test components or behaviors.

Changes

Windows E2E configuration

Layer / File(s)	Summary
Configure disabled E2E tests ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml	The aws-e2e-ote job now sets TEST_ARGS with disabled test features.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: vincent056

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The patch only adds TEST_ARGS in a ci-operator YAML job config; no It/Describe/Context/When test titles were added or changed.
Test Structure And Quality	✅ Passed	Only a CI job YAML env var changed; no Ginkgo test code was added or modified, so the checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Only CI job env was changed; no new Ginkgo tests or API/resource references were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only updates ci-operator YAML env for aws-e2e-ote; no new Ginkgo tests or SNO-sensitive logic were added, so this check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a CI job TEST_ARGS change in a ci-operator YAML; no manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	Only a ci-operator YAML job config changed; no process-level binary code or stdout logging paths were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a ci-operator TEST_ARGS line changed; no new Ginkgo tests or network code were added, so IPv6/disconnected compatibility isn’t applicable.
No-Weak-Crypto	✅ Passed	Diff only adds TEST_ARGS to a YAML ci job; no weak-crypto code or secret comparisons are introduced.
Container-Privileges	✅ Passed	The only change is a TEST_ARGS env var in aws-e2e-ote; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The change only adds a TEST_ARGS env var with monitor names; no passwords, tokens, PII, session IDs, or hostnames are introduced.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: disabling platform monitors in the aws-e2e-ote job.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrasouli
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/windows-machine-config-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@rrasouli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-ote	openshift/windows-machine-config-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@rrasouli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.