setup assisted-installer version v2.55 - #82624
Conversation
WalkthroughAdds v2.55 OpenShift CI operator configurations for four assisted components, covering version-pinned image builds, promotion targets, resource requests, generated metadata, and lint, unit, subsystem, and end-to-end test workflows. ChangesAssisted v2.55 CI pipelines
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml (1)
116-130: 🩺 Stability & Availability | 🔵 TrivialArm64 day2 job pulls floating
:latestdev-stream images instead of v2.55-pinned ones.
AGENT_DOCKER_IMAGE,CONTROLLER_IMAGE, andINSTALLER_IMAGEreference...-ds-main/...:latestrather than the v2.55 promoted images used elsewhere in this file, so this job's results aren't tied to the version being validated by this config. This may be an intentional, pre-existing convention for arm64 coverage; worth confirming it wasn't meant to track v2.55 images instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml` around lines 116 - 130, The e2e-metal-assisted-day2-arm-workers configuration uses floating dev-stream images instead of v2.55-pinned images. Update AGENT_DOCKER_IMAGE, CONTROLLER_IMAGE, and INSTALLER_IMAGE to reference the promoted v2.55 image locations and tags consistent with the other jobs in this configuration, while preserving the arm64-specific settings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml`:
- Around line 116-130: The e2e-metal-assisted-day2-arm-workers configuration
uses floating dev-stream images instead of v2.55-pinned images. Update
AGENT_DOCKER_IMAGE, CONTROLLER_IMAGE, and INSTALLER_IMAGE to reference the
promoted v2.55 image locations and tags consistent with the other jobs in this
configuration, while preserving the arm64-specific settings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 55026630-0216-4415-ae0a-0a973b96baa4
⛔ Files ignored due to path filters (8)
ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yamlci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit
Adds OpenShift CI configurations for the
v2.55branches of Assisted Installer, Assisted Installer Agent, Assisted Service, and Assisted Image Service. The configurations define component image builds, resource defaults, promotion to theedge-infrastructurenamespace, and release candidates based on OCP 5.0 nightly streams.They also establish lint, unit, subsystem, generated-code, mirror-publish, and extensive end-to-end test coverage across bare-metal, OCI, cloud, virtualization, and platform-specific scenarios.